Re: tramp (2.5.2-pre emacs-28/3dd47bde7a87bef332bd53f3e73c8d2bc64910c8); Implementation of tramp-connection-properties doesn't match its docstring

[Michael Albinus]

Kai Tetzlaff <kai@tetzlaff.eu> writes:

Hi Kai,

> The documentation of `tramp-connection-properties` claims:
>
>   List of static connection properties.
>   Every entry has the form (REGEXP PROPERTY VALUE).  The regexp
>   matches remote file names. ...
>
> However, the actual implementation of `tramp-get-hash-table` uses the
> following code for the lookup:
>
>     (dolist (elt tramp-connection-properties)
>       (when (tramp-compat-string-search
>            (or (nth 0 elt) "")
>            (tramp-make-tramp-file-name key 'noloc 'nohop))
>
> where (on current emacs) `tramp-compat-string-search` translates to a
> simple `string-search` which uses REGEXP to do a simple string search
> instead of a regexp search.
>
> IMO the docstring describes the desired functionality which means that
> the implementation is incorrect.

Thanks for the report! This is an obvious error, I will fix it. First I
need to check whether similar errors happened when
tramp-compat-string-search was added to Tramp last summer. I'll keep you
informed.

Best regards, Michael.