Re: [Tsp-devel] [PATCH] RPM package fixes

[Eric Noulard]

2007/11/9, Robert de Vries <address@hidden>:
> Hi all,
>
> When I was checking the contents of the current RPM package, I noticed a
> couple of things.
> The profile files for tsp are no longer necessary, now that the TSP libraries
> are in /usr/lib, the binaries in /usr/bin. I also removed them
> from /usr/share/tsp/scripts.

I think it would be better to keep them in /usr/share/tsp/scripts
while removing thing from /etc/profile.d
this way one may install tsp at unusual location
(may be with rpm -i --prefix=/unsual/path)
and eventually use those scripts files.

> There are two configuration files in /usr/bin (stub_gdisp_config.xml and
> stub_targa_config.xml). I moved them to the example directory
> in /usr/share/tsp.

That's better.

> I split the base tsp package into tsp and tsp-devel (classic division).
> In tsp-devel contains all the files needed for development of tsp
> applications, in our case only include files.
> I removed the attr statements to make everything executable. This is not
> needed and wrong for the files in /usr/share/tsp and in /usr/lib/pkgconfig

OK with those too.

>
> Maybe we should rename tsp-apidoc to tsp-devel-doc to better indicate the
> intended audience.

This package is ill-named in the first place since you may find
developer documentation AND user doc for example for the
tsp applications;

see for examples sub-modules of TSP_Applications:
http://www.ts2p.org/tsp/API_doc/html/group__TSP__Applications.html
(this generated doc is oudated but the idea is here)


>
> The resulting packages (on Fedora 7) are with this patch with sizes in bytes:
> 995159 tsp-0.8.4cvs-1.i386.rpm
> 819600 tsp-apidoc-0.8.4cvs-1.i386.rpm
> 618278 tsp-debuginfo-0.8.4cvs-1.i386.rpm
> 64213   tsp-devel-0.8.4cvs-1.i386.rpm
>
> Comments?

Seems Ok with the 2 remarks:

   1) keep scripts in /usr/share/tsp/scripts
   2) may be tsp-apidoc should be renamed as tsp-doc?
       (but the doxygen content is not finished [yet])

You are very active on TSP those days keep going :=)
-- 
Erk