|
From: | Kevin Martin |
Subject: | Re: [Varnamproject-discuss] Suggestions file validity |
Date: | Thu, 22 May 2014 22:50:17 +0530 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hello Kevin,
It is much better. Few suggestions.
- - is_file_valid should be is_file_exists
- - Don't use printf for reporting error. Set the error using
"set_last_error" call. Writing to the console from a library is not
recommended as you don't know what type of application is using this
library.
- --
On 5/20/14 11:43 PM, Kevin Martin wrote:
> Created a is_file_valid() function in utils.c. I have modified the commit
> as suggested. Please check the 'suggestions_file' branch.
>
> https://github.com/lonesword/libvarnam/tree/suggestions_file
>
Cheers,
Navaneeth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org
iQEcBAEBCgAGBQJTfHlmAAoJEHFACYSL7h6kkw4H/2J/AJ12bItBpqzQsRoUTvQG
1sQjGc76q0gzM7Nypjly8T+j5kRu/SgyWotK9WO90X2g/KRIeBxSc38gokdE0YAw
WWuQ5bir/Nmw4MId3tdjekd59fLnRhLN/TSxEVlVE/eNbdsdrGleyKDSglzc2otV
vdcWwX0LjiJa/MPWTdB9cKpdVkQDUhoN13dtgFQaee1MNT+gqiqb9/YcpBOvt5pO
jhjCCsFMZG00z5iksW7PDmcun4Jx70SJ6eWWoVjRlUbhbXZBfTQbtX2Wook0ff1w
PmfDhOkpr8yADDchWnv3yS3mYKxfw9nzrfISPc+anAfuCzjyAofL5aa3iDK3i9s=
=uWX0
-----END PGP SIGNATURE-----
[Prev in Thread] | Current Thread | [Next in Thread] |