varnamproject-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Varnamproject-discuss] Suggestions file validity


From: Kevin Martin
Subject: Re: [Varnamproject-discuss] Suggestions file validity
Date: Sun, 25 May 2014 00:25:44 +0530

I have made some changes. I have added a testcase under initialization.c. Please review.

https://github.com/lonesword/libvarnam/commit/2b67f282bc9a4798672372ad5d668faf7958a373

That is not the latest commit. I have done another commit undoing the previous incorrect implementation.

Also, are some of the test cases bound to fail? Because when I ran runtests.sh, I got the following output :

Running suite(s): core
 util
 commandline
Using /usr/local/lib/libvarnam.so
Transliterating 'varnam'
  വർനം
Using /usr/local/lib/libvarnam.so
ruby: /home/kevin/Projects/libvarnam/words-table.c:97: vwt_optimize_for_huge_transaction: Assertion `(handle->internal)->known_words' failed.
Aborted
Using /usr/local/lib/libvarnam.so
Error at text: not-valid-indic-word. Invalid format. Each line should contain pattern and word separated with a single space
Processed 1 word(s). 0 word(s) passed. 1 word(s) failed.
Failed words are logged to - output/varnamc-train-failures.txt
68%: Checks: 50, Failures: 1, Errors: 15
/home/kevin/Projects/libvarnam/tests/initialization.c:116:E:initialization:initialize_using_lang_code:0: (after this point) Received signal 11 (Segmentation fault)
(null):-1:S:transliteration:basic_transliteration:0: (after this point) Test timeout expired
(null):-1:S:transliteration:dependent_vowel_rendering:0: (after this point) Test timeout expired
(null):-1:S:transliteration:cancellation_character_should_force_independent_vowel_form:0: (after this point) Test timeout expired
(null):-1:S:transliteration:indic_digit_rendering:0: (after this point) Test timeout expired
(null):-1:S:learning:starting_and_trailing_special_chars_should_be_removed:0: (after this point) Test timeout expired
(null):-1:S:learning:words_with_unknown_letters_should_be_rejected:0: (after this point) Test timeout expired                                                                                  
(null):-1:S:learning:basic_learning:0: (after this point) Test timeout expired                                                                                                                 
(null):-1:S:learning:words_with_repeating_characters_will_not_be_learned:0: (after this point) Test timeout expired                                                                            
(null):-1:S:learning:numbers_will_be_ignored_while_learning:0: (after this point) Test timeout expired                                                                                         
(null):-1:S:learning:confidence_should_get_updated_for_existing_words:0: (after this point) Test timeout expired                                                                               
(null):-1:S:learning:is_known_word:0: (after this point) Test timeout expired                                                                                                                  
(null):-1:S:learning:learn_from_multiple_open_handles:0: (after this point) Test timeout expired                                                                                               
/home/kevin/Projects/libvarnam/tests/vst-compilation.c:39:E:transliteration:get_all_tokens:0: (after this point) Test timeout expired                                                          
/home/kevin/Projects/libvarnam/tests/vst-compilation.c:71:E:transliteration:prefix_tree:0: (after this point) Test timeout expired                                                             
/home/kevin/Projects/libvarnam/tests/varnamc_tests.c:32:F:varnamc:learn_failures_file_should_be_created_upon_failures:0: Assertion '0==exitcode' failed: 0==0, exitcode==34304

only 68% pass. Is that normal?


On Sat, May 24, 2014 at 2:21 PM, Kevin Martin <address@hidden> wrote:
I will look into it and make necessary changes. Thanks.


On Sat, May 24, 2014 at 9:29 AM, Navaneeth K N <address@hidden> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hello Kevin,

That's incorrect. See how other features are tested
(https://github.com/varnamproject/libvarnam/blob/master/tests/learning.c#L66).
We use a library called "Check" to perform assertions and manage test
suits. So you need to write tests that way.

cmake -DBUILD_TESTS=true  - Will compile test files
make && sudo make install
cd tests
./runtests

On 5/23/14 7:06 PM, Kevin Martin wrote:
> I have added a test case for is_file_exists at testcases.c. I'm not sure if
> this is what you had in mind.
>

- --
Cheers,
Navaneeth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJTgBk2AAoJEHFACYSL7h6kKJkH/16xsDnfyv1X5T4qv5gzoYRY
jLeZ8WS1RyyfngazGZNzOSYlbfMhYuaMwJw+e/o9phtCeaF36K1yYXlnCN2fDigP
P/rWFlt2p2VaeTXLten6sCN8Jgdm3fFfUnwl4z1d7PYRUb38foIKACS/jZQLbxkZ
j7XHhx+N3Ef0tklAKgWxLbonCASCoc9Rm36sgnrYehRxKiuXYWFu/K+7DUr2xJJu
t5E5e/OKLlW3zGiRIf3nwk7agP2X08ULLXxx4IsYsGJR2/J5/lGv3SxINnmF7Bfq
fgH6aUdUv0gkD1s3hKm0p0IJ4nsLHXPXrHsSaH4z6fS1wyRV/PYVXCWvp+lyhJo=
=Nohp
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]