Re: [Varnamproject-discuss] Suggestions file validity

[Navaneeth K N]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Let us meet up on IRC tomorrow 8.30-9AM

On 5/25/14 10:07 AM, Kevin Martin wrote:
> When can we have the next IRC meeting?
> 
> 
> On Sun, May 25, 2014 at 12:25 AM, Kevin Martin
> <address@hidden>wrote:
> 
>> I have made some changes. I have added a testcase under initialization.c.
>> Please review.
>>
>>
>> https://github.com/lonesword/libvarnam/commit/2b67f282bc9a4798672372ad5d668faf7958a373
>>
>> That is not the latest commit. I have done another commit undoing the
>> previous incorrect implementation.
>>
>> Also, are some of the test cases bound to fail? Because when I ran
>> runtests.sh, I got the following output :
>>
>> Running suite(s): core
>>  util
>>  commandline
>> Using /usr/local/lib/libvarnam.so
>> Transliterating 'varnam'
>>   വർനം
>> Using /usr/local/lib/libvarnam.so
>> ruby: /home/kevin/Projects/libvarnam/words-table.c:97:
>> vwt_optimize_for_huge_transaction: Assertion
>> `(handle->internal)->known_words' failed.
>> Aborted
>> Using /usr/local/lib/libvarnam.so
>> Error at text: not-valid-indic-word. Invalid format. Each line should
>> contain pattern and word separated with a single space
>> Processed 1 word(s). 0 word(s) passed. 1 word(s) failed.
>> Failed words are logged to - output/varnamc-train-failures.txt
>> 68%: Checks: 50, Failures: 1, Errors: 15
>> /home/kevin/Projects/libvarnam/tests/initialization.c:116:E:initialization:initialize_using_lang_code:0:
>> (after this point) Received signal 11 (Segmentation fault)
>> (null):-1:S:transliteration:basic_transliteration:0: (after this point)
>> Test timeout expired
>> (null):-1:S:transliteration:dependent_vowel_rendering:0: (after this
>> point) Test timeout expired
>> (null):-1:S:transliteration:cancellation_character_should_force_independent_vowel_form:0:
>> (after this point) Test timeout expired
>> (null):-1:S:transliteration:indic_digit_rendering:0: (after this point)
>> Test timeout expired
>> (null):-1:S:learning:starting_and_trailing_special_chars_should_be_removed:0:
>> (after this point) Test timeout expired
>> (null):-1:S:learning:words_with_unknown_letters_should_be_rejected:0:
>> (after this point) Test timeout
>> expired
>>
>> (null):-1:S:learning:basic_learning:0: (after this point) Test timeout
>> expired
>>
>> (null):-1:S:learning:words_with_repeating_characters_will_not_be_learned:0:
>> (after this point) Test timeout
>> expired
>>
>> (null):-1:S:learning:numbers_will_be_ignored_while_learning:0: (after this
>> point) Test timeout
>> expired
>>
>> (null):-1:S:learning:confidence_should_get_updated_for_existing_words:0:
>> (after this point) Test timeout
>> expired
>>
>> (null):-1:S:learning:is_known_word:0: (after this point) Test timeout
>> expired
>>
>> (null):-1:S:learning:learn_from_multiple_open_handles:0: (after this
>> point) Test timeout
>> expired
>>
>> /home/kevin/Projects/libvarnam/tests/vst-compilation.c:39:E:transliteration:get_all_tokens:0:
>> (after this point) Test timeout
>> expired
>> /home/kevin/Projects/libvarnam/tests/vst-compilation.c:71:E:transliteration:prefix_tree:0:
>> (after this point) Test timeout
>> expired
>> /home/kevin/Projects/libvarnam/tests/varnamc_tests.c:32:F:varnamc:learn_failures_file_should_be_created_upon_failures:0:
>> Assertion '0==exitcode' failed: 0==0, exitcode==34304
>>
>> only 68% pass. Is that normal?
>>
>>
>> On Sat, May 24, 2014 at 2:21 PM, Kevin Martin <address@hidden
>>> wrote:
>>
>>> I will look into it and make necessary changes. Thanks.
>>>
>>>
>>> On Sat, May 24, 2014 at 9:29 AM, Navaneeth K N <address@hidden> wrote:
>>>
> Hello Kevin,
> 
> That's incorrect. See how other features are tested
> (
> https://github.com/varnamproject/libvarnam/blob/master/tests/learning.c#L66
> ).
> We use a library called "Check" to perform assertions and manage test
> suits. So you need to write tests that way.
> 
> cmake -DBUILD_TESTS=true  - Will compile test files
> make && sudo make install
> cd tests
> ./runtests
> 
> On 5/23/14 7:06 PM, Kevin Martin wrote:
>>>>>> I have added a test case for is_file_exists at testcases.c. I'm not
> sure if
>>>>>> this is what you had in mind.
>>>>>>
> 
>>>>
>>>>
>>>
>>
> 

- -- 
Cheers,
Navaneeth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJTiEEFAAoJEHFACYSL7h6kECAIAKxe/odNeiao7WtZFHmwZKn6
/w4/e1KVp6Hd9JU3EjIIMIBJj1TAW+jONxv2nQEJYO/i5rL059HL04SCYxDKs3hM
mmrMPjOpKNHbfU08BbE3NOATIkSIEAAsuWspOK8U0hRUdqEV63JdPKRc/XBYa9Ql
2caRboTaxMx6SST0p3NKyUl52YLCX3KID/xWw0S8zmdFUV79gmRZk9kIVes2S58Z
I0adQJhPZb8pBdDj+kxPFMLiwj3HxZF6iqTv5MB/NzYpqQxzFTW3rDTOFwy8L375
D84fLKsJ+saF3jAZs8OWtEzTr8jlW424UpnUpdj2znrW2dDuBuu2EpAHc0elutk=
=Kt2P
-----END PGP SIGNATURE-----