[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Varnamproject-discuss] Pull request

From: Kevin Martin
Subject: Re: [Varnamproject-discuss] Pull request
Date: Sat, 31 May 2014 22:38:09 +0530

I cloned your repo, compiled it and ran the tests : Still says 71%: Checks: 49, Failures: 0, Errors: 14

Then it went on to show the timeouts.

On Sat, May 31, 2014 at 10:03 PM, Kevin Martin <address@hidden> wrote:
I did not run the tests until Travis build failed. Sorry I did not do it before I made the PR.

On Sat, May 31, 2014 at 10:02 PM, Kevin Martin <address@hidden> wrote:
I have made a pull request, but there are some problems :

Travis build fails due to an assertion on varnamc_tests line 32. This means there is some problem with learn from file. When I used 'varnamc --learn-from <file>' it gave me an assertions error :

assertion '(handle->internal)->known_words' failed.

Will look into this and try patching it. Seems like I broke something when I added validity check.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]