Re: [Varnamproject-discuss] Issues

[Kevin Martin]

Solved most of the new issues:

https://github.com/lonesword/libvarnam/commit/dfbd710c0f31b41d0d0e4d9f49444a65425ba0b1

Please take a look at lru_cache function inside vst_get_stem(). As of now they are faulty, because varnam does not stem properly with the cache. Once I comment out the cache, everything is fine. I'll resolve this today (17th Aug) but I'm almost clueless. Are there any obvious mistakes I'm making with lru_cache?

I ran "valgrind ./stemmer stemmer_input.txt" on the example and it did not show anything other than 2 "Conditional jump or move depends on uninitialised value(s)". There are other memory leaks. I will fix those too today.

On Fri, Aug 15, 2014 at 3:56 PM, Kevin Martin <address@hidden> wrote:

Solved all issues except #64, #69, #56 and #55

#69 - stem() should not be util.h. No idea where to put stem(). The only downside of not putting it in a header file is that the tests won't work. If we do not have direct access to stem(), we will have to call varnam_learn() and then see if the stemmed word was learned (by querying the db) to test the stemmer functionality.

#64 - make get_stem() more efficient.

The prepared statements have been stored in handle->internal. Still figuring out how to use the lru cache and where.

#55 - I used to run valgring on examples/stemmer.c. Since that example is now removed from the project, how should I run the valgrind tests? An option is to run it on examples/learning since varnam_learn() calls stem().

#56 - integrate stemmer.