Re: [Varnamproject-discuss] Good to merge

[Navaneeth K N]

Hello Kevin,

I have merged the changes. I will test again and cut a release.

On 30-Aug-2014, at 10:49 pm, Kevin Martin <address@hidden> wrote:

> Pull request made. 
> 
> I'm definitely going to continue contributing to varnam! I have to make sure 
> that the stemmer indeed improves transliteration. It was really great to have 
> spent the last 3 months working on varnam. Learned a lot more than I had 
> anticipated! Also, I believe that varnam is a project that can make a pretty 
> huge impact on FOSS movement in India. So I'll definitely be doing what I can 
> as time permits. Thanks again for letting me work on this project.
> 
> On Sat, Aug 30, 2014 at 10:43 AM, Navaneeth K N <address@hidden> wrote:
> Hi,
> 
> I tested everything and it looks good. Thanks for fixing the issues.
> 
> I wanted you to merge all your changes into a single commit and send a
> pull request with that commit. Please write elaborate commit message,
> check this for example[1].
> 
> To merge all your commits to a single commit, I guess all you have to do is,
> 
> 
>         git checkout master
>         git checkout -b stemmer_final
>         git merge --squash varnam_stemmer
>         git commit
>         git push origin stemmer_final
> 
> Then send PR from `stemmer_final` branch. I will merge it and deploy to
> varnamproject.com after that.
> 
> Thanks again for working on this. It was great working with you and I
> expect you will continue contributing to varnam and other open-source
> initiatives.
> 
> 
> [1]:
> https://github.com/varnamproject/libvarnam/commit/bd7102f8c61468c36a32fe84c9e16d187f8116aa
> 
> --
> Cheers,
> Navaneeth
>