Re: [Wesnoth-dev] patch for fixed-point calculations

[Yann Dirson]

On Sun, Feb 06, 2005 at 11:11:37PM +0100, Jon Daniel wrote:
> Yann Dirson <address@hidden> wrote:
> > 
> > I've also tried to write compatibility macros to have the previous
> > behaviour, although I've not tested them yet (see util.hpp).
> > 
> 
> Nice work converting all the performance critical functions to use fixed
> point math.
> One problem is that you cluttered the normal floating point code with
> the fixed point macros.

What "normal floating point code" do you think about precisely ?

It would not be that easy to select the floating/fixed-point
calculation with a fine grain, since the APIs induce the type of the
variables used as parameters, etc.  I did all of this conversion with
something like 3 or 4 initial function prototype changes, and I'm not
that sure they were all independant...

-- 
Yann Dirson    <address@hidden> |
Debian-related: <address@hidden> |   Support Debian GNU/Linux:
                                    |  Freedom, Power, Stability, Gratis
     http://ydirson.free.fr/        | Check <http://www.debian.org/>