[Wesnoth-patches] [patch #3849] fix for bug #11389: Battle statistics are modified when replaying a file

[Dave Gordon]

Follow-up Comment #2, patch #3849 (project wesnoth):

Huh? How so?

I thought the point of using lexically-scoped objects rather than flags to
hold state information such as "statistics disabled" was that it made the
code exception-safe; no matter how the flow of control leaves the inner
block, the destructor *will* be called.

Anyway, I checked by replaying a save from a campaign, and it called the
statistics::disabler destructor exactly as many times as the constructor :-)

However, while checking this I found another anomaly in the statistics, to do
with whether the stats are cleared at the start of the game (which depends on
whether there's a snapshot in the savefile and whether the user asked to see
the replay). So there may be a different (better?) fix that addresses this as
well ... more later!


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?func=detailitem&item_id=3849>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/