Re: [Acl-devel] [PATCH 0/2] Handle quoting of backslashes more clearly

[Jeff Mahoney]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 12/5/15 5:45 PM, Andreas Grünbacher wrote:
> Jeff,
> 
> 2015-12-02 16:52 GMT+01:00  <address@hidden>:
>> I've also added test infrastructure to handle testing for
>> usernames like this by adding a helper library that provides the
>> getpw* and getgr* routines used in the test code and redirects
>> the reads to project-local copies of passwd and group.  I'll
>> admit it's a bit overkill, but while it worked well to choose
>> standard system usernames for testing like 'bin' and 'daemon', I
>> needed a way to test the quoting code and that required 
>> non-standard usernames.
> 
> Did you write this just for libacl? Would it make sense to move it 
> into a separate package to allow other test suites to use it as
> well? For example, xfstests depens on a local user / group
> "fsgqa".

Yeah, I did, but there's no reason it couldn't be used for other project
s.

> Other than that, the code looks okay, so I'll add your two patches
> in their current form for now.

Great, thanks!

- -Jeff


- -- 
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2

iQIcBAEBCAAGBQJWZYYAAAoJEB57S2MheeWyK34P/0oyLgr1ruuIRGjKeU4JznLJ
5drFvMfs4/yBNL7XB7E6Q+IlmFdAh9af5cHrORWr1w93GgVmweIuyKOcJh/pzuPM
B7A0RKugaq+gSh/7QZ5HkiHT8wcMfF78Qg0a2IZ7XnKN7QE7vphBkB5YL2tFuwvc
2oQgqhyNsNZw9P93koh49rTk9YpZ98hlyS4ppkvjy3tQeiBuEnYtWLLwXJJebYmh
Je/BnBHgioSwyPo4ne7fUeSLKsFdJsPEhQI69Ue8/n50BVQdHVa37owjbOq8lbMu
clyGC0Peh0T1uaoev5fGbTTS17YVms/tfVHbYrUcXrnN78q47yjP0r4YHno1qxyf
R1eCCk9uvj8yWr989yaKt4sPFzLbxaBJ8ZQo/y/HE6zHccROUW9aiG6Z/Y6CRzVC
ZiOu2dS8pBfQRPg/wW3mboOqNbi8MqeeFHmtdzyKO7G+UT95cpZdVIP6OnDo1e1e
AbD2jJr3SPY4dXTCODCs0O9J2fEXFgNET84oR3vMnSq1Il31ysmBbBkD3GbFVK+Z
3Nx7bffX1z1kICeYBWuliowq3MT8I/AEn8cSTj6J9+TxM8wq/KikLnxwtdG5VvZ5
x58qlvbgiHK9O1f33b/vCEqyqu7/FFGaIg2xbSsYr1oDjrlulq5wDnr1J2vqVJIs
r6/5YC1mKQimQ/LC5eT9
=XBPa
-----END PGP SIGNATURE-----