[patch #10284] ax_jni_include_dir: don't cache result (it's broken)

[Matt Whitlock]

URL:
  <https://savannah.gnu.org/patch/?10284>

                 Summary: ax_jni_include_dir: don't cache result (it's broken)
                 Project: GNU Autoconf Archive
               Submitter: mwhitlock
               Submitted: Sun 09 Oct 2022 05:49:56 AM UTC
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Sun 09 Oct 2022 05:49:56 AM UTC By: Matt Whitlock <mwhitlock>
The *AX_JNI_INCLUDE_DIR* macro was violating the first rule of
*AC_CACHE_CHECK*: "The _commands-to-set-it must have no side effects_ except
for setting the variable _cache-id_."[1] Specifically, *JNI_INCLUDE_DIRS* was
being modified within the code block that was only supposed to be setting the
value of *ac_cv_jni_header_path*. This was causing *JNI_INCLUDE_DIRS* to be
incorrect/incomplete when *ac_cv_jni_header_path* was initialized from an
Autoconf cache file.

Since the tests to find the JNI header paths are so trivial, there is nothing
to be gained by caching the results. The most straightforward fix is not to
cache, and that is the fix provided in this patch.

[1]
https://www.gnu.org/software/autoconf/manual/html_node/Caching-Results.html






    _______________________________________________________
File Attachments:


-------------------------------------------------------
Date: Sun 09 Oct 2022 05:49:56 AM UTC  Name:
0001-ax_jni_include_dir-don-t-cache-result.patch  Size: 3KiB   By: mwhitlock

<http://savannah.gnu.org/patch/download.php?file_id=53818>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10284>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/