autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: Initial draft patch: AS_EXECUTABLE_P


From: Tim Van Holder
Subject: RE: Initial draft patch: AS_EXECUTABLE_P
Date: Tue, 23 Jan 2001 21:13:04 +0100

> AS_EXECUTABLE_P should provably be named AS_OS_EXECUTABLE. This is one of
> the few cases when Autoconf is dealing with the OS, not with the
> libraries. Another case would be the maximal length of the arguments.
Okidoki.

> Besides, why that "_P" on the end? My first guess was "profiling" as in
> libc_p.a.
Stands for 'predicate', as in 'an expression resolving to true or false'.
An emacs-ism; I suppose - but this was suggested before as a viable naming
choice for such a macro.

> > +chmod 100 conftest.file
> > +if test -x conftest.file; then
> > +  as_executable_p="test -x"
> > +elif test -f conftest.file; then
> > +  as_executable_p="test -f"
> Are you sure this won't break Cygwin? OS/2-EMX? DJGPP?
I'm certain it doesn't break DJGPP (the fact that the test file starts
with a sharp-bang sequence causes it to be found as executable), as that's
what I'm running.
Can't say for Cygwin or OS/2; but that's why I called this a _draft_ patch.
It works on my system, but I want others to try it to make sure it works
for them as well.

> They all will probably fall back to "test -f" which won't be successul if
> ".exe" is omitted, i.e. "test -f m4" will fail for m4.exe as opposed to
> "test -x m4" that should find it.
Yes, but then again, the current autoconf always uses "test -f", so there's
no decrease in functionality.

> I cannot check it myself, but I can only approve this patch if it at least
> doesn't break Cygwin.
And I can't guarantee that. I don't plan on downloading all of Cygwin just
to get its bash; if Cygnus' (current) bash can be downloaded separately, by
all means let me know where; that'll allow me to use CONFIG_SHELL to test
the Cygwin case.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]