autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: some underquotings in the testsuite


From: Pavel Roskin
Subject: FYI: some underquotings in the testsuite
Date: Thu, 15 Feb 2001 18:22:39 -0500 (EST)

Hello!

The second argument to AT_INIT must be double quoted if it's a
constant text, according to the comment before AT_INIT definition.

The same rule applies to other macros taking parts of configure.ac as
arguments.

However, the argument to _AT_CHECK_AC_MACRO was not double quoted. Also
the argument to AT_INIT in AT_CONFIGURE_AC was missing the second pair of
quotes around its constant parts.

This patch has to user-visible effects except few quotes that were missing
in the CPP-related tests.

Regards,
Pavel Roskin

______________________________
--- ChangeLog
+++ ChangeLog
@@ -1,3 +1,11 @@
+2001-02-07  Pavel Roskin  <address@hidden>
+
+       * tests/atspecific.m4 (AT_CONFIGURE_AC): Double quote constant
+       part of the second argument to AT_DATA.
+       * tests/compile.at (AC_PROG_CPP with warnings): Fix underquoting
+       in a call to _AT_CHECK_AC_MACRO.
+       (AC_PROG_CPP without warnings): Likewise.
+
 2001-02-11  Jim Meyering  <address@hidden>

        Ensure that even `autoscan --version' fails when e.g.,
--- tests/atspecific.m4
+++ tests/atspecific.m4
@@ -29,14 +29,14 @@
 m4_define([AT_CONFIGURE_AC],
 [AT_CLEANUP_FILES(env-after state*)dnl
 AT_DATA([configure.ac],
-[AC_INIT
+[[AC_INIT
 AC_CONFIG_AUX_DIR($top_srcdir)
 AC_CONFIG_HEADER(config.h:config.hin)
-AC_STATE_SAVE(before)
+AC_STATE_SAVE(before)]
 $1
-AC_OUTPUT
+[AC_OUTPUT
 AC_STATE_SAVE(after)
-])])
+]])])


 # AT_CHECK_AUTOCONF(FLAGS, [EXIT-STATUS = 0], STDOUT, STDERR)
--- tests/compile.at
+++ tests/compile.at
@@ -146,12 +146,12 @@
 chmod +x mycpp

 _AT_CHECK_AC_MACRO(
-[AC_PROG_CPP
+[[AC_PROG_CPP
 # If the preprocessor is not strict, just ignore
 test "x$ac_c_preproc_warn_flag" = xyes &&
   AC_MSG_ERROR([preprocessor has no warning option], 77)
 CPP="./mycpp $CPP"
-AC_CHECK_HEADERS(stdio.h autoconf_io.h)])
+AC_CHECK_HEADERS(stdio.h autoconf_io.h)]])

 AT_CHECK_DEFINES(
 [/* #undef HAVE_AUTOCONF_IO_H */
@@ -176,7 +176,7 @@
 chmod +x mycpp

 _AT_CHECK_AC_MACRO(
-[# Ignore if /lib/cpp doesn't work
+[[# Ignore if /lib/cpp doesn't work
 if AC_TRY_COMMAND([/lib/cpp </dev/null >&2]); then :; else
   AC_MSG_ERROR([preprocessor doesn't work], 77)
 fi
@@ -184,7 +184,7 @@
 AC_PROG_CPP
 test "x$ac_c_preproc_warn_flag" != xyes &&
   AC_MSG_ERROR([failed to detect preprocessor warning option])
-AC_CHECK_HEADERS(stdio.h autoconf_io.h)])
+AC_CHECK_HEADERS(stdio.h autoconf_io.h)]])

 AT_CHECK_DEFINES(
 [/* #undef HAVE_AUTOCONF_IO_H */
______________________________





reply via email to

[Prev in Thread] Current Thread [Next in Thread]