autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: typo in m4sugar.m4


From: Akim Demaille
Subject: Re: typo in m4sugar.m4
Date: Tue, 04 Jan 2005 10:26:59 +0100
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux)

>>> "Stepan" == Stepan Kasal <address@hidden> writes:

 > Hi,
 >   I believe I have found a typo in m4sugar.m4 comment and a minor typo
 > in an old changelog entry.

 > OK to commit?

Please do.

 > Index: lib/m4sugar/m4sugar.m4
 > ===================================================================
 > RCS file: /cvsroot/autoconf/autoconf/lib/m4sugar/m4sugar.m4,v
 > retrieving revision 2.79
 > diff -u -r2.79 m4sugar.m4
 > --- lib/m4sugar/m4sugar.m4   3 Jan 2005 22:54:21 -0000       2.79
 > +++ lib/m4sugar/m4sugar.m4   4 Jan 2005 01:31:37 -0000
 > @@ -85,12 +85,12 @@
 >  # Define DST as the definition of SRC.
 >  # What's the difference between:
 >  # 1. m4_copy([from], [to])
 > -# 2. m4_define([from], [to($@)])
 > +# 2. m4_define([to], [from($@)])
 >  # Well, obviously 1 is more expansive in space.  Maybe 2 is more expansive

expensive twice

 >  # in time, but because of the space cost of 1, it's not that obvious.
 >  # Nevertheless, one huge difference is the handling of `$0'.  If `from'
 >  # uses `$0', then with 1, `to''s `$0' is `to', while it is `from' in 2.
 > -# The user will certainly prefer see `from'.
 > +# The user will certainly prefer to see `to'.
 >  m4_define([m4_copy],
 >  [m4_define([$2], m4_defn([$1]))])
 

 >  2003-05-22  Paolo Bonzini  <address@hidden>
 
 > -    * lib/m4sugar/m4sh.m4 [AS_REQUIRE]: actually use the 2nd
 > +    * lib/m4sugar/m4sh.m4 (AS_REQUIRE): actually use the 2nd
 >      parameter

While you're at it could you make it "Actually use the 2nd parameter."
(upper case and period).  Thanks!





reply via email to

[Prev in Thread] Current Thread [Next in Thread]