autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: reorganized config.status


From: Ralf Wildenhues
Subject: Re: reorganized config.status
Date: Tue, 2 Aug 2005 15:30:34 +0200
User-agent: Mutt/1.4.1i

Hi Stepan, others,

This is a reply to
http://lists.gnu.org/archive/html/libtool-patches/2005-08/msg00002.html
which starts at
http://lists.gnu.org/archive/html/libtool-patches/2005-07/msg00128.html
and
http://lists.gnu.org/archive/html/autoconf-patches/2005-07/msg00032.html

* Stepan Kasal wrote on Mon, Jul 25, 2005 at 03:40:44PM CEST:
>   I have reorganized a substantial part of status.m4.
> The most important change is that config.status now contains one
> big for-loop for all $CONFIG_FOOS.  This means that the common
> code (like _AC_CONFIG_SPLIT) is now expanded only once.

This patch breaks Libtool CVS HEAD.  I suppose it's Libtool which once
again uses unpublished interface, but am unsure.  Maybe you can see an
easy way out here.

> 2005-07-25  Stepan Kasal  <address@hidden>
> 
>       Rewrite substantial part of lib/autoconf/status.m4.
*snip*

This part:
>       (AC_LIST_FILES, AC_LIST_HEADERS, AC_LIST_LINKS, AC_LIST_COMMANDS):
>       Replaced by this ...
>       (_AC_LIST_TAGS): ... new common macro.

This causes this code to fail (libtool/m4/ltdl.m4, LTDL_INIT):

| # In order that ltdl.c can compile, run AC_CONFIG_HEADERS for the user
| # if they did not call it themself.  This is so that ltdl.h can pick up
| # the parent projects config.h file, The first file in AC_CONFIG_HEADERS
| # must contain the definitions required by ltdl.c.
| m4_ifset([AC_LIST_HEADERS],
|     [CONFIG_H=`echo "AC_LIST_HEADERS" | $SED 's,^[[     ]]*,,;s,[[ 
:]].*$,,'`],
|   [CONFIG_H=config.h;AC_CONFIG_HEADERS([config.h])])
| AC_SUBST([CONFIG_H])

We compute CONFIG_H, because we later do a 
| DEFS = -DHAVE_CONFIG_H="<$(CONFIG_H)>" -DLTDL

in libtool/libltdl/Makefile.am so that argz.h works both in-tree as well
as out-of-tree.

The patch proposed on the other list is broken, as _AC_LIST_TAGS does
not contain a list of tags (and is obviously not published interface
either).

* Peter Ekberg wrote on Mon, Aug 01, 2005 at 10:14:09AM CEST:
> Peter O'Gorman wrote:
> > Richard Moseley wrote:
> > | This patch will handle both the old usage of AC_LIST_HEADERS and the new
> > | _AC_LIST_TAGS choosing the appropriate one defined. Otherwise the
> > | configuration will fail with an error about a duplicate use of
> > | AC_CONFIG_HEADERS.

*snip*
> > | --- ChangeLog.orig        2005-07-29 08:55:43.000000000 +0100
> > | +++ ChangeLog     2005-07-29 08:52:36.000000000 +0100
> > | @@ -1,3 +1,8 @@
> > | +2005-07-29  Richard Moseley  <address@hidden>
> > | +
> > | + * m4/ltdl.m4 (LTDL_INIT): Handle in addition the new name for
> > | + AC_LIST_HEADERS which is _AC_LIST_TAGS.
> > | +
> > 
> > Committed to HEAD and branch-2-0.
> 
> This patch breaks it for me (error from cvs-head):
> 
> ../configure: line 11979: syntax error near unexpected token `;'
> ../configure: line 11979: `CONFIG_H=`echo " config.h:config-h.in" | $SED
> 's,^[ ]*,,;s,[ :].*$,,'` ;;'

I can reproduce this as well: CVS HEAD Autoconf and Libtool.

> Must I upgrade autoconf?

No, that should not be necessary for this.

> In that case, is that common?

Well, some interdependency troubles can happen.  CVS HEAD Libtool kind
of wants something more recent than Autoconf 2.59.   We try not to do
this without good reason, though (and I believe we have not decided
whether to require 2.59 or something more recent for branch-2-0 -- there
are at least a couple of nasty system-dependent limitations in 2.59
which turn up in Libtool's test suite).

Regards,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]