Re: AT_KEYWORDS failure: cmdline OR-combinations

[Ralf Wildenhues]

Hi Stepan,

* Stepan Kasal wrote on Wed, Aug 17, 2005 at 12:58:39PM CEST:
> On Tue, Aug 16, 2005 at 08:33:12PM +0200, Ralf Wildenhues wrote:
> > Sure.  Feel free to adjust the patch accordingly.
> 
> OK, I've prepared a variation of your patch.
> It passes "make check" on my GNU/Linux.
> Could you please try "make check" on Solaris?

Passes on Solaris.  This test, however:
| 21: m4sh.at:252        AS_VERSION_COMPARE

loops endlessly (in awk).  Will post a patch later.

> If there are no further comments, I'll commit it, after a few days.

Just a typo below.

Cheers,
Ralf

*snip*
>  # Selected test groups.
> -test -z "$at_groups" && at_groups=$at_groups_all
> +if test -z "$at_groups"; then
> +  at_groups=$at_groups_all
> +else
> +  # Sort the tests, removing duplicates:
> +  at_groups=`echo $at_groups | tr ' ' "$as_nl" | sort -nu`
> +  # and add banners.  (Passing at_groups_all is tricky, ... see the
> +  # comment strating with words "Passing at_groups is tricky.")

Typo.  Also, I'd write:
 ... see the comment starting with "Passing at_groups is tricky.")

> +  at_groups=`echo "$at_groups$as_nl $at_groups_all" |
> +    awk ['BEGIN { FS = "@" } # Effectively switch off field splitting.
> +     /^$/ { next }  # Ignore the empty line.
> +     !/ / { groups++; selected[$ 0] = 1; next }
> +     # The last line, containing at_groups_all.
> +     {
> +             n = split($ 0, a, " ")
> +             # If there are several tests, select their banners:
> +             if (groups > 1) {
> +                     for (i = 1; i <= n; i++) {
> +                             if (a[i] ~ /^banner-/)
> +                                     banner = a[i]
> +                             else if (banner != "" && selected[a[i]] == 1)
> +                                     selected[banner] = 1
> +                     }
> +             }
> +             for (i = 1; i <= n; i++)
> +                     if (selected[a[i]] == 1)
> +                             list = list " " a[i]
> +             print list
> +     }']`
> +fi
>  m4_divert_pop([PARSE_ARGS_END])dnl
>  m4_divert_push([HELP])dnl
>