autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: reorganized config.status


From: Ralf Wildenhues
Subject: Re: reorganized config.status
Date: Thu, 18 Aug 2005 13:59:42 +0200
User-agent: Mutt/1.4.1i

Hi Stepan,

* Stepan Kasal wrote on Tue, Aug 16, 2005 at 12:15:51PM CEST:
> 
> > +Since they have to appear before @file{config.status}
> > +is created, they may be called no later than in an argument to
> > address@hidden
> 
> This formulation has two problems:
> 
> 1) Many users would not understand what the "no later" means.
> They see the ordering in configure.ac by their own eyes, but they cannot
> see the final ordering in configure as clearly as we do.

ACK.

> 2) Though there are sometimes reasons to call AC_CONFIG_FOOS
> from AC_CONFIG_COMMANDS_PRE, it's not usual.  So we shouldn't mention
> AC_CONFIG_COMMANDS_PRE here.

ACK.

> I modified your latest doc patch, merged it with the previous one, and
> I'm attaching the result here.
> 
> If there are no comments, I'll commit after a few days.

Comments below.  Please mention your commit, so I can finally commit the
pending patch to Libtool and get this over with.  Thanks.

Regards,
Ralf

> Index: doc/autoconf.texi
> ===================================================================
> RCS file: /cvsroot/autoconf/autoconf/doc/autoconf.texi,v
> retrieving revision 1.925
> diff -u -r1.925 autoconf.texi
> --- doc/autoconf.texi 6 Jul 2005 21:39:31 -0000       1.925
> +++ doc/autoconf.texi 16 Aug 2005 09:59:21 -0000
> @@ -2648,8 +2648,8 @@
>  operating systems.  As an alternative to passing @option{-D} options to
>  the compiler, @command{configure} scripts can create a C header file
>  containing @samp{#define} directives.  The @code{AC_CONFIG_HEADERS}
> -macro selects this kind of output.  It should be called right after
> address@hidden
> +macro selects this kind of output.  Though it can be called anywhere in
> address@hidden, it is customary to call it right after @code{AC_INIT}.

Nit pickingly, this is not true: aclocal fails if you call
AC_CONFIG_HEADERS before AC_INIT; it is silently ignored when called
after AC_OUTPUT.

>  The package should @samp{#include} the configuration header file before
>  any other header files, to prevent inconsistencies in declarations (for
> @@ -2697,6 +2697,19 @@
>  to prepend and/or append boilerplate to the file.
>  @end defmac
>  
> address@hidden AH_HEADER
> +This macro is defined as the name of the first declared config header
> +and undefined if no config headers have been declared up to this point.
> +A third-party macro may, for example, require use of a config header
> +without invoking AC_CONFIG_HEADERS twice like this:

Please put a comma after twice.  I did not understand the sentence
without it.

> +
> address@hidden
> +AC_CONFIG_COMMANDS_PRE(
> +     [m4_ifndef([AH_HEADER], [AC_CONFIG_HEADERS([config.h])])])
> address@hidden example
> +
> address@hidden defmac
> +
>  @xref{Configuration Actions}, for more details on @var{header}.
>  
>  @menu
*rest snipped*




reply via email to

[Prev in Thread] Current Thread [Next in Thread]