autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Fwd: Re: proposed gnulib-related additions to Autoconf]


From: Ralf Wildenhues
Subject: Re: [Fwd: Re: proposed gnulib-related additions to Autoconf]
Date: Fri, 3 Mar 2006 06:00:46 +0100
User-agent: Mutt/1.5.9i

Hi Paul,

* Paul Eggert wrote on Thu, Mar 02, 2006 at 09:49:26PM CET:
> Ralf Wildenhues <address@hidden> writes:
> 
> > Not sure if I like all those white space changes (several instances in
> > several files) introducing TABs in comments, and making this patch much
> > larger than necessary (and more difficult to review for lined-up
> > underlines ;-)
> 
> Sorry about that; you can use "diff -b" on the old versus the new
> to avoid that.  Admittedly it's annoying; I'll try not to do more.

It has two very small drawbacks: first, I'd have to actually apply the
patch before reading it.  ;-)
But also we still use CVS which makes history digging stumble over each
close white space change and source file reorganization.  Surely that's
more of an argument against CVS than against those changes in the first
place.

> > It'd be nice to  s|$|dnl|  for all the AC_REQUIRE and AC_BEFORE.
> 
> But that makes the source harder to read.  I'd rather that we worked
> toward an approach that allowed nicer source layout.  In the meantime
> I'm not sure it's worth the minor benefit in avoiding empty lines in
> 'configure'.

Fine with me.  It makes the output a bit harder to read.  ;-)

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]