Re: really small nitpick

[Ralf Wildenhues]

Hi Laurence, Bruce,

* Laurence Darby wrote on Sun, Mar 26, 2006 at 05:01:19PM CEST:
> Bruce Korb wrote:
> > No.  Autoscan should:
> > 
> >    if test -f configure.ac

> >    else
> >       echo "NOTE: creating configure.ac file" >&2
> >       configure_file=configure.ac
> >       touch configure.ac
> >    fi
> > 
> > i.e. do the right thing and signal the user what is being done.
> > Eliminate extra unnecessary steps.  :)  Of course, that needs
> > to be translated into perl.  Thanks - Bruce

Not quite, IMVHO.  The user is responsible for creating `configure.ac'.
I think it's a feature that this file is not changed automatically.  And
also the manual explains that one possibility is to just rename
`configure.scan' to `configure.ac' after manual checking.  I for one am
always wary of overwriting created files.

> The first two checks are already there, so it's quite simple.  I made a
> small patch for it, could it be applied please?

This code is used by more than just autoscan, and it's necessary that
the other programs fail when they do not find a suitable configure.ac.

I'm checking this patch in instead, which should remove the warning.

Cheers,
Ralf

        * bin/autoscan.in: The value of find_configure_ac should be
        checked for existence, so we don't barf over a nonexisting
        configure.ac.  Reported by Laurence Darby <address@hidden>.

Index: bin/autoscan.in
===================================================================
RCS file: /cvsroot/autoconf/autoconf/bin/autoscan.in,v
retrieving revision 1.103
diff -u -r1.103 autoscan.in
--- bin/autoscan.in     6 Jan 2006 00:10:37 -0000       1.103
+++ bin/autoscan.in     26 Mar 2006 21:22:59 -0000
@@ -631,7 +631,7 @@
 init_tables;
 scan_files;
 output ('configure.scan');
-if ($configure_ac)
+if (-f $configure_ac)
   {
     check_configure_ac ($configure_ac);
   }