Re: [PATCH] Make AC_COMPUTE_INT public

[Stepan Kasal]

Hello,
  I haven't fully reviewed your patch, so just a few trivial
comments:

1) My cleanup of _AC_COMPUTE_INT actually changes only
_AC_COMPUTE_INT_COMPILE, so it is orthogonal to this patch.

2) I think there is a typo in your news entry:

On Wed, Jun 28, 2006 at 03:20:05PM +0200, Paolo Bonzini wrote:
> +** The functionality of the undocumented _AC_COMPUTE_INT is now provided
> +  by a public and documented macro, AC_COMPUTE_INT.  The parameters to the
> +  two functions are different, so autoupdate will change the old private name
> +  to the new one.  _AC_COMPUTE_INT may be removed in a future release.

"autoupdate will not change", right?

3)
> -# _AC_COMPUTE_INT(EXPRESSION, VARIABLE, PROLOGUE, IF-FAILS)
> +# _AC_COMPUTE_INT(EXPRESSION, VARIABLE, PROLOGUE, [IF-FAILS])
>  # ---------------------------------------------------------
> -m4_define([_AC_COMPUTE_INT],
> +m4_defun([_AC_COMPUTE_INT],
>  [AC_LANG_COMPILER_REQUIRE()dnl
>  if test "$cross_compiling" = yes; then
...
> +# AC_COMPUTE_INT(MESSAGE, CACHE-ID, EXPRESSION, [PROLOGUE = 
> DEFAULT-INCLUDES],
> +#             [IF-FAILS])
> +# ---------------------------------------------------------
> +m4_defun([AC_COMPUTE_INT],
> +[AC_CACHE_CHECK([$1], [$2],
> +[if test "$cross_compiling" = yes; then

The new version does not contain AC_LANG_COMPILER_REQUIRE()--is that
intentional?  If yes, could you please explain?

Thanks for your work,
        Stepan Kasal