autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNU Autoconf 2.60] testsuite: 3 120 failed


From: Ralf Wildenhues
Subject: Re: [GNU Autoconf 2.60] testsuite: 3 120 failed
Date: Thu, 12 Oct 2006 18:52:09 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

[ removing bug-autoconf, adding bug-libtool ]

Hello Paul,

* Paul Eggert wrote on Wed, Oct 11, 2006 at 11:52:13PM CEST:
> Stepan Kasal <address@hidden> writes:
> 
> > 3) AS_EXECUTABLE_P is reduced to `test -x' (on modern hosts).
> > (See the attached autoconf-20061009-bin-sh-3.patch.)
> > IIRC, the current implementation of AS_EXECUTABLE_P is a result of a
> > long discussion.  In particular, mere `test -x' was refused because
> > it is true for a directory, and one might encounter a directory named
> > `perl' somewhere in PATH.
> 
> OK, but we should still have a macro that expands to plain "test -x",
> since sometimes it is useful to test whether the installer has the
> x permission on a file or directory or whatever.
> 
> I installed this patch instead; it preserves the semantics of
> AS_EXECUTABLE_P and adds a new macro AS_TEST_X that behaves like "test -x".

This patch kills $as_executable_p.  This breaks libtool.m4 from
Libtool-1.5.22 (and possibly CVS HEAD, I haven't checked).
Yes, it uses $as_executable_p instead of AS_EXECUTABLE_P, but since
neither are documented, it's not even clear which would be worse.

If it were only for Libtool, it'd be bad enough but fixable (with some
pushing for another release soon), but google tells me there are more
problem candidates out there.

Apologies in advance for more such bugs out there; I know Libtool uses
quite a few undocumented Autoconf things (some of which are known), but
I haven't had the time to do an audit yet.  OTOH, I would be much more
inclined to do so if Autoconf documented more of m4sh.  (And yes, I very
well acknowledge that I was part in postponing those documentation
additions back then.)

Thank you,
Ralf

> 2006-10-11  Paul Eggert  <address@hidden>
> 
>       * lib/m4sugar/m4sh.m4 (AS_TEST_X): New macro.
>       (AS_EXECUTABLE_P): Use as_test_x rather than as_executable_p.
>       (_AS_TEST_PREPARE): Set as_test_x rather than as_executable_p.
>       Use a better substitute, by inspecting the output of "ls"
>       rather than just using ":".
>       * lib/autoconf/general.m4 (_AC_LINK_IFELSE): Use AS_TEST_X
>       rather than AS_EXECUTABLE_P, since we needn't worry about
>       non-regular files here.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]