autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Prefer AM_CPPFLAGS to @CPPFLAGS@


From: Stepan Kasal
Subject: Re: Prefer AM_CPPFLAGS to @CPPFLAGS@
Date: Mon, 11 Jun 2007 12:47:36 +0200
User-agent: Mutt/1.4.2.3i

Hello Ralf,

On Sun, Jun 10, 2007 at 09:13:14AM +0200, Ralf Wildenhues wrote:
> > -CPPFLAGS = -DDATADIR='"$(datadir)"' @@CPPFLAGS@@
> > +AM_CPPFLAGS = -DDATADIR='"$(datadir)"'
> 
> Why not show both (the non-Automake case is useful and conveys
> additional information)?

A nice idea, but:

It would make the node too complex.
The node "19.5 How Do I `#define' Installation Directories?" is in
the FAQ section, so people might expect it is short.

More importantly: The node explains that a naive AC_DEFINE hardwires
an incorrect path and (though there are ways to hardwire the correct
one (one of them is to let `make' compute the actual path (which can
be done either by extending CPPFLAGS (example 1) or by a make-created
header file (example 2)))) you rather should not hardwire paths at all.

And you are effectively suggesting to replace "example 1" by a pair
of examples.  I do not think this is a place where the information
should be added, at least as it stands now.

Have a nice day,
        Stepan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]