Re: Patch proposal: Add --clean options to unbootstrap a project.

[Ralf Wildenhues]

Hello Benoit,

* Benoit Sigoure wrote on Tue, Jun 19, 2007 at 12:17:07AM CEST:
> Quoting Ralf Wildenhues <address@hidden>:
>> * Benoit Sigoure wrote on Sun, Jun 17, 2007 at 01:16:35AM CEST:
>
> 2007-06-17  Benoit Sigoure  <address@hidden>
>
>       * bin/autoconf.as, bin/autoheader.in, bin/autoreconf.in: New option
>       `--clean'.
>       * NEWS: Mention it.
>       * bin/autoreconf.in (&run_make): New.
>       (&autoreconf_current_directory): Use it.  Honor the $clean variable.
>       * lib/Autom4te/General.pm ($clean): New boolean value.
>       (getopt): Handle `--clean'.
>       * lib/Autom4te/FileUtils.pm ($SIMPLE_BACKUP_SUFFIX): Export it.
>       * tests/torture.at: Test the new feature.

Please mention the doc changes in the ChangeLog.  For example:

        * doc/autoconf.texi (autoconf Invocation)
        (autoreconf Invocation, autoheader Invocation): Document them.


[ autoreconf ]
> +      system ('rm -rf autom4te.cache');

Ah, one bit that is not general: the name of the cache directory may be
customized, see `(autoconf.info)Customizing autom4te'.  I suppose a nice
and clean implementation would have `autom4te --clean' and let
autoreconf invoke that.  It in turn would remove the cache directory
only if caching was enabled and a relative path, but rather not with an
absolute path.

Apologies for not stumbling over that in my last review.

> --- lib/Autom4te/FileUtils.pm 17 May 2006 02:17:58 -0000      1.12
> +++ lib/Autom4te/FileUtils.pm 18 Jun 2007 22:06:55 -0000

This file needs a copyright year update.

Other than that, the patch looks good to me.

Cheers, and thanks for all your work on this,
Ralf