autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: another old patch: use the vertical bar as sed delimiter


From: Jim Meyering
Subject: Re: another old patch: use the vertical bar as sed delimiter
Date: Mon, 24 Sep 2007 08:38:22 +0200

Paul Eggert <address@hidden> wrote:

> Jim Meyering <address@hidden> writes:
>
>> Is the concern that "|" might be used as a path separator?
>> Does any shell use that?
>
> The concern was that someone might put "|" in a directory name, and
> that the directory might appear in a PATH.  That patch was part of a
> more-general "support as many characters as possible in file names"
> drive that I was doing at the time.  It was easy to support "|" in
> file names there, so the patch did it.

>> Initially I also changed
>>
>>     $ grep '\<sed ['\''"]s[^/|]' lib/autotest/general.m4
>>     AUTOTEST_PATH=`AS_ECHO(["$AUTOTEST_PATH"]) | sed "s&:&$PATH_SEPARATOR&g"`

Since this AUTOTEST_PATH / PATH_SEPARATOR sed transformation works with
arbitrary values for $AUTOTEST_PATH, I'm changing the & to | there, too.

> I didn't see any problems in your patch; thanks.

Thanks for the review!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]