Re: parallel autotest [1/3]: Refactor testsuite driver loop.

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 6/18/2008 1:52 PM:
| Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de> writes:
|
|> rather than
|>   2 3 11 failed, 4 5 10 passed unexpectedly
|>
|> in the summary.  I didn't bother fixing those variables which we do not
|> output; the question mark patterns are more, thus incur higher overhead.
|
| Good explanation.  Perhaps a comment would be in order as a followup patch?

I've added the following:

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkhaWSgACgkQ84KuGfSFAYD5ewCdG9gwrGyq71u+oZth0Zp9EJ+t
TVwAnAn2n83TJbOR1w3yNkUWYS69X9jW
=MRx6
-----END PGP SIGNATURE-----

>From a8eb89699993bbcb4d7f278ab8fece54f64e1334 Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Thu, 19 Jun 2008 07:02:20 -0600
Subject: [PATCH] Add comment explaining recent patch.

* lib/autotest/general.m4 (AT_INIT) <at_pass_list>: Explain choice
of * vs. ? globbing.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog               |    6 ++++++
 lib/autotest/general.m4 |    1 +
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 3e72893..065a75b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-06-19  Eric Blake  <address@hidden>
+
+       Add comment explaining recent patch.
+       * lib/autotest/general.m4 (AT_INIT) <at_pass_list>: Explain choice
+       of * vs. ? globbing.
+
 2008-06-19  Ralf Wildenhues  <address@hidden>
 
        * lib/autoconf/status.m4 (_AC_OUTPUT_LINK): Do not warn when not
diff --git a/lib/autotest/general.m4 b/lib/autotest/general.m4
index 3c983fc..90fce9f 100644
--- a/lib/autotest/general.m4
+++ b/lib/autotest/general.m4
@@ -1166,6 +1166,7 @@ done
 # Wrap up the test suite with summary statistics.
 cd "$at_helper_dir"
 
+# Use ?..???? when the list must remain sorted, the faster * otherwise.
 at_pass_list=`for f in */pass; do echo $f; done | sed '/\*/d; s,/pass,,'`
 at_skip_list=`for f in */skip; do echo $f; done | sed '/\*/d; s,/skip,,'`
 at_xfail_list=`for f in */xfail; do echo $f; done | sed '/\*/d; s,/xfail,,'`
-- 
1.5.5.1