autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Document, test, and fix AT_ARG_OPTION, AT_ARG_OPTION_ARG.


From: Eric Blake
Subject: Re: Document, test, and fix AT_ARG_OPTION, AT_ARG_OPTION_ARG.
Date: Thu, 17 Jun 2010 14:00:39 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Lightning/1.0b2pre Mnenhy/0.8.2 Thunderbird/3.0.4

On 06/15/2010 11:09 PM, Ralf Wildenhues wrote:
> Undocumented good features are a waste of goodness!  :-)
> 
> I'm not sure in which way this code may overlap, conflict, or profit
> from, Gary's option parsing endeavor, but a code search showed me that
> the macros are used in third-party code already, so might as well get
> these right.  Sorry if there is duplication, this came from 2003.

And ultimately, I'd like to see this moved to the M4sh level (then both
autoconf and autotest get it for free).  But that will be post-2.66.

But since we haven't touched that code in a long time, and people are
using it in the wild, this patch looks fine to me, with one nit fixed first:

> +m4_define_default([AT_first_option_tr],
> +               [m4_bpatsubst(m4_defn([AT_first_option]), -, _)])dnl

Let's use [_] here, in case _ is a macro name.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]