Re: [PATCH] getopt: new Autom4te::Getopt module

[Eric Blake]

On 01/17/2012 11:11 AM, Stefano Lattarini wrote:
> * lib/Autom4te/General.pm (getopt): Move the guts of its
> implementation ...
> * lib/Autom4te/Getopt.pm (parse_options): .. into this function
> in the new Autom4te::Getopt module.  This will make it simpler
> for the implementation to be shared with other projects (right
> now, Automake).
> * lib/Automake/Makefile.am (dist_perllib_DATA): Add the new
> module.

Looks reasonable to me; but right now, for Autom4te files shared between
automake and autoconf, we tend to let automake be the master, so that we
pick up later changes in both projects.  I suppose that will be a
followup patch once you fold this in to automake?

> +++ b/lib/Autom4te/Makefile.am
> @@ -17,6 +17,7 @@
>  
>  perllibdir = $(pkgdatadir)/Autom4te
>  dist_perllib_DATA = \
> +  Getopt.pm \
>    C4che.pm \
>    ChannelDefs.pm \
>    Channels.pm \

Any reason you didn't keep this list sorted?

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature