Re: [PATCH 7/7] maint: fix or disable failing syntax-check rules

[Jim Meyering]

Eric Blake wrote:

> On 01/21/2012 04:14 AM, Jim Meyering wrote:
>> From: Jim Meyering <address@hidden>
>>
>> * cfg.mk (local-checks-to-skip): List failing tests, so we skip
>> them, for now.
>> (old_NEWS_hash): Update.
>> (exclude_file_name_regexp--sc_file_system): Exempt doc/autoconf.texi
>> for it's uses of "Filesystem Hierarchy Standard".
>> ---
>>  cfg.mk |   16 ++++++++++++++--
>>  1 files changed, 14 insertions(+), 2 deletions(-)
>
> Thanks again for doing this.  Hmm, I wonder, can we do:
>
> File@/system Hierarchy Standard
>
> in the .texinfo sources, which would thus obscure the word from the
> syntax check, while having no impact on the rendered text (assuming the
> text does not occur at any point where a line break might be attempted)?
>  If so, we could avoid this exclusion.

Good idea.  I verified that autoconf.info is unchanged and that a
search for the one-word variant in the .pdf finds the two changed uses.

Thanks for the quick reviews.  With this, I'm pushing the series.

>From b035df38e0d888bab264245623c8cd72bd05db4d Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 21 Jan 2012 12:05:02 +0100
Subject: [PATCH] maint: fix or disable failing syntax-check rules

* cfg.mk (local-checks-to-skip): List failing tests, so we skip
them, for now.
(old_NEWS_hash): Update.
* doc/autoconf.texi: Per suggestion from Eric Blake, obfuscate
the first word of "Filesystem Hierarchy Standard" as File@/system
so it continues to render as one word, yet doesn't trigger the
syntax-check prohibition.
---
 cfg.mk            |   15 +++++++++++++--
 doc/autoconf.texi |    7 +++++--
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index 68bc23f..77e0487 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -109,7 +109,18 @@ autom4te-update:

 # Tests not to run.
 local-checks-to-skip ?= \
-  changelog-check sc_unmarked_diagnostics
+  changelog-check                      \
+  sc_GPL_version                       \
+  sc_cast_of_alloca_return_value       \
+  sc_m4_quote_check                    \
+  sc_makefile_at_at_check              \
+  sc_prohibit_HAVE_MBRTOWC             \
+  sc_prohibit_always-defined_macros    \
+  sc_prohibit_always_true_header_tests \
+  sc_prohibit_magic_number_exit                \
+  sc_prohibit_stat_st_blocks           \
+  sc_unmarked_diagnostics
+

 # Always use shorthand copyrights.
 update-copyright-env = \
@@ -117,7 +128,7 @@ update-copyright-env = \
   UPDATE_COPYRIGHT_MAX_LINE_LENGTH=72

 # Prevent incorrect NEWS edits.
-old_NEWS_hash = 6a8aa950938fba063f3dc2b0e11e67e8
+old_NEWS_hash = 33207c359dd7db17cc0cd151da6b9567

 exclude_file_name_regexp--sc_prohibit_undesirable_word_seq = ^maint\.mk$$
 exclude_file_name_regexp--sc_prohibit_test_minus_ao = \
diff --git a/doc/autoconf.texi b/doc/autoconf.texi
index 3c70ea4..247a46c 100644
--- a/doc/autoconf.texi
+++ b/doc/autoconf.texi
@@ -22516,11 +22516,14 @@ Site Defaults
 fi
 @end example

address@hidden Filesystem Hierarchy Standard
address@hidden Leave this use of ``File system'' rendered as one word, but
address@hidden slightly obfuscated so as not to trigger the syntax-check 
prohibition.
address@hidden File@/system Hierarchy Standard
 @cindex FHS

 Another use of @file{config.site} is for priming the directory variables
-in a manner consistent with the Filesystem Hierarchy Standard
address@hidden ``File system'', but slightly obfuscated, as above.
+in a manner consistent with the File@/system Hierarchy Standard
 (FHS).  Once the following file is installed at
 @file{/usr/share/config.site}, a user can execute simply
 @code{./configure --prefix=/usr} to get all the directories chosen in
--
1.7.9.rc2.2.g183d6