autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] syntax-check: remove SPACE-TAB sequence


From: Stefano Lattarini
Subject: Re: [PATCH 3/3] syntax-check: remove SPACE-TAB sequence
Date: Fri, 16 Nov 2012 17:15:13 +0100

On 11/16/2012 04:45 PM, Eric Blake wrote:
> On 11/16/2012 04:48 AM, Stefano Lattarini wrote:
>> Hi Peter.
>>
>> On 11/16/2012 12:38 PM, Peter Rosin wrote:
>>> On 2012-11-16 11:37, Stefano Lattarini wrote:
>>>> * lib/autoconf/c.m4 (_AC_PROG_CC_C99): Here.  Was causing a
>>>> failure in the 'space_tab' syntax check.
>>>>
>>>> Signed-off-by: Stefano Lattarini <address@hidden>
>>>> ---
>>>>  lib/autoconf/c.m4 | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/lib/autoconf/c.m4 b/lib/autoconf/c.m4
>>>> index 0802f85..b1edf17 100644
>>>> --- a/lib/autoconf/c.m4
>>>> +++ b/lib/autoconf/c.m4
>>>> @@ -1349,7 +1349,7 @@ dnl Try
>>>>  dnl GCC           -std=gnu99 (unused restrictive modes: -std=c99 
>>>> -std=iso9899:1999)
>>>>  dnl IBM XL C      -qlanglvl=extc1x (V12.1; does not pass C11 test)
>>>>  dnl IBM XL C      -qlanglvl=extc99
>>>> -dnl               (pre-V12.1; unused restrictive mode: -qlanglvl=stdc99)
>>>> +dnl             (pre-V12.1; unused restrictive mode: -qlanglvl=stdc99)
>>>>  dnl HP cc -AC99
>>>>  dnl Intel ICC     -std=c99, -c99 (deprecated)
>>>>  dnl IRIX  -c99
>>>>
>>>
>>> But the surrounding uses TABs, not spaces.
>>>
>> Well spotted.  I've fixed that locally.
> 
> Autoconf has not yet made the global switch away from TABs, but I'm
> willing to go that route to match what other GNU projects have done.  In
> the meantime, fixing the syntax check makes sense, so ACK to either what
> you proposed, or your fixed version with local TAB fixes in this area.
> 
Thanks Eric for your quick review.  I've pushed all three patches in
this series (the last one with the use of TABs rather than spaces, to
favour consistency with surrounding code).

Regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]