Re: [PATCH 1/2] AC_SITE_LOAD: convert '\' in PATH to '/' on OS/2

[KO Myung-Hun]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi/2.

Eric Blake wrote:
> On 05/28/2015 11:43 PM, KO Myung-Hun wrote:
>> echo of some shells such as pdksh recognizes '\' as an escape 
>> character. So when echoing a path, the result can be corrupted. 
>> For examples, echo x:\usr\bin will be x:\usin.
>> 
>> * lib/autoconf/general.m4 (AC_SITE_LOAD): Convert '\' in PATH to
>>  '/' on OS/2. --- lib/autoconf/general.m4 | 9 +++++++++ 1 file 
>> changed, 9 insertions(+)
>> 
>> diff --git a/lib/autoconf/general.m4 b/lib/autoconf/general.m4 
>> index a7f1439..6173b83 100644 --- a/lib/autoconf/general.m4 +++ 
>> b/lib/autoconf/general.m4 @@ -1951,6 +1951,15 @@ do || 
>> AC_MSG_FAILURE([failed to load site script $ac_site_file]) fi 
>> done + +if test -n "$OS2_SHELL"; then +  # Backslashes into 
>> forward slashes: +  # The following OS/2 specific code is 
>> performed AFTER config.site +  # has been loaded to allow users 
>> to change their environment there. +  # This strange code is 
>> necessary to deal with handling of backslashes by +  # ksh. + 
>> export PATH=$(expr "$PATH" | tr '\\' /) +fi
> 
> Why can't your config.site set this properly in the first place? 
> Plus, doing it in your config.site would have the benefit of 
> working on all existing packages, rather than requiring packages to
> be rebuilt with a newer autoconf.
> 

It's possible. I'm doing so already. However, this approach makes all
users put this code into their config.site.

It's not good idea to require additional files and codes to run
configure. And newer projects will use newer autoconf which has this
codes. They will not require additional config.site any more to
execute their configure.

- -- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (OS/2)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFVaZvIE9YstvghgroRAm+yAKC95vGVlnefpeUy3MZtV/A4BmmFnwCghC6p
+jCTe1KSkbEil3ultk/uPP0=
=oCSp
-----END PGP SIGNATURE-----