[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix an infinitely recursing example
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] Fix an infinitely recursing example |
|
Date: |
Wed, 2 Nov 2016 06:21:07 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/02/2016 12:58 AM, Quinn Grier wrote:
> The "single" macro infinitely recurses because its expansion contains
> the unquoted text " single-". The "double" macro almost has the same
> problem, but it is protected by extra quotes. In any case, the macro
> names being repeated in the macro definitions is not necessary.
>
> This commit changes the macro names to "foo" and "bar", which are taken
> from a very similar example in the GNU M4 1.4.17 manual. See lines 1971
> to 1980 of v1.4.17:doc/m4.texi in the GNU M4 Git repository.
> ---
> doc/autoconf.texi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Good catch! I'll install this alongside other patches that I'm testing
this week.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature