autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Add quotes in AS_IF test for gid_t


From: Sam James
Subject: [PATCH] Add quotes in AS_IF test for gid_t
Date: Wed, 7 Feb 2024 03:33:30 +0000

Noticed when building Emacs:
```
* checking type of array argument to getgroups... ./configure: 42782: test: =: 
unexpected operator
```

This turns out to be because of missing quotes in AS_IF for ac_cv_type_gid_t
in AC_TYPE_GETGROUPS.

* lib/autoconf/types.m4 (AC_TYPE_GETGROUPS): Use quotes in AS_IF test for gid_t.
  Reported indirectly by Eli Schwartz <eschwartz93@gmail.com>.
---
 lib/autoconf/types.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/autoconf/types.m4 b/lib/autoconf/types.m4
index 8ed2f155..2f23ddaf 100644
--- a/lib/autoconf/types.m4
+++ b/lib/autoconf/types.m4
@@ -268,7 +268,7 @@ dnl this uses AC_COMPILE_IFELSE rather than AC_LINK_IFELSE.
 AC_CACHE_CHECK([type of array argument to getgroups], ac_cv_type_getgroups,
 [# If AC_TYPE_UID_T says there isn't any gid_t typedef, then we can skip
 # everything below.
-AS_IF([test $ac_cv_type_gid_t = no],
+AS_IF([test "$ac_cv_type_gid_t" = no],
   [ac_cv_type_getgroups=int],
   [# Test programs below rely on strict type checking of extern declarations:
   # 'extern int getgroups(int, int *); extern int getgroups(int, pid_t *);'
-- 
2.43.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]