automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 57-my-last-mying-changes.patch


From: Tom Tromey
Subject: Re: 57-my-last-mying-changes.patch
Date: 22 Feb 2001 18:30:36 -0700

>>>>> "Akim" == Akim Demaille <address@hidden> writes:

Akim> Six, six for them! (I'm not counting those for file handles,
Akim> which perl refuses as my, not sure to understand why).

The way file handles work is another reason to dislike Perl.  At
least, I've always found them confusing.

Akim>   * automake.in: Mying changes.
Akim>   * Makefile.am (maintainer-check): Check the stability of the
Akim>   number of uses of `local'.

This is ok if you make one small change.

Akim> +   [0-5] ) \
Akim> +     echo "Wow, congrats!  There are $$locals \`local' now!." >&2; \
Akim> +     echo "Please update Makefile.am (maintainer-check)." >&2; \
Akim> +   ;; \

I think this case should `exit 1'.
We expect exactly a certain number.
If this changes then there is a bug -- either one got deleted by
accident, or the person forgot to update Makefile.am.

Tom



reply via email to

[Prev in Thread] Current Thread [Next in Thread]