Re: Bug with conditionals. [PATCH]

[Richard Boulton]

I submitted a patch for this a little while ago, but received no response.

If there is an alternate forum in which I should be submitting patches, or
if I can do anything to make the patch clearer / more readily applicable,
please let me know.

I attach an updated patch against current CVS HEAD.

-- 
Richard

On Wed, Jun 06, 2001 at 02:33:16AM +0100, Richard Boulton wrote:
> I came across this problem a few days ago: just narrowed it down to a
> sensible test case.
> 
> With CVS automake, if LDADD is set from both a conditional variable
> and an AC_SUBST() variable, the _DEPENDENCIES target gets set incorrectly,
> having a @TRUE@ preceding it (for each of the conditional variables).
> 
> I attach a patch containing a testcase demonstrating the problem
> (cond11.test), and a proposed fix (by removing redundant TRUE conditions
> in variable_conditions_reduce().)
> 
> I'm not sure this patch is the right way to go about this, but with it the
> testsuite (including cond11.test) passes.
> 
> For the example in cond11.test, CVS automake gives me a Makefile.in
> containing the lines:
> @TRUE@@address@hidden = faz.la
> @TRUE@@address@hidden =
> 
> I would expect the lines:
> @address@hidden = faz.la
> @address@hidden =
> 
> PS: is this list still the correct place for patches?  I thought I saw some
> mention of setting up a new list for them a while back, but can't find
> anything about that on the webpage.
> 
> -- 
> Richard

patch
Description: Text document