[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: variable substitution refs [PATCH]
From: |
Richard Boulton |
Subject: |
Re: variable substitution refs [PATCH] |
Date: |
Sat, 4 Aug 2001 14:01:11 +0100 |
User-agent: |
Mutt/1.2.5i |
On Fri, Aug 03, 2001 at 10:31:13PM -0600, Tom Tromey wrote:
> Thanks. I agree with your analysis and your patch.
> However, I'm checking in a slight variant. I made a new global to
> hold the pattern we use to match substitution references.
> Doing that is somewhat self-documenting; it means we don't have to add
> a comment explaining what some random regular expression is meant to
> do.
Okay, that seems good to me.
> Nothing unfortunate about that. However, I got the messages in
> reverse order. Akim numbers his patches to handle this problem; that
> is one convenient approach.
I think I'll start doing that then.
> Richard> cond13.test \
> Richard> cond14.test \
> Richard> cond15.test \
> Richard> +cond16.test \
>
> There is no cond15.test.
> Odd.
I think an earlier patch of mine got lost. I'll resubmit it.
I'll definitely start numbering my patches.
--
Richard