Re: nobase.test

[Ralf Wildenhues]

Hello Patrick,

* Patrick Welche wrote on Sat, Sep 02, 2006 at 01:52:10PM CEST:
> In nobase.test:
> 
> # Remove the 'x' bits just for fun.  (Peter O'Gorman said: "If an
> # upstream source tarball does not use the autotools, it is sometimes
> # easier to build if it is modified to use them. Then a patch is
> # generated, and applied to the unpacked clean sources during the
> # build. patch(1) knows nothing about permissions, so executable bits
> # etc can disappear.")
> chmod a-x install-sh
> 
> yet removing the x bits just makes the test fail for me:

Yes, I think when Automake moved to use the result of AC_PROG_MKDIR_P,
this support for non-executable install-sh was dropped again:
http://lists.gnu.org/archive/html/automake/2006-04/msg00091.html
http://lists.gnu.org/archive/html/bug-automake/2006-06/msg00017.html

I say we drop the test and require that install-sh be executable.
After all, this is so much easier to do.

OK to apply?

Cheers,
Ralf

        * NEWS: Mention that `install-sh' needs executable permissions.
        * tests/nobase.test: Adjust.

Index: NEWS
===================================================================
RCS file: /cvs/automake/automake/NEWS,v
retrieving revision 1.314
diff -u -r1.314 NEWS
--- NEWS        28 Aug 2006 16:04:24 -0000      1.314
+++ NEWS        3 Sep 2006 07:33:01 -0000
@@ -1,3 +1,11 @@
+New in 1.9c:
+
+* Miscellaneous changes:
+
+  - The script `install-sh' needs to have executable permissions for
+    a package to work correctly.  The permissions may have been lost
+    by work of a patch or version control tool.
+
 New in 1.9b:
 
 * Version requirements:
@@ -103,6 +111,9 @@
     per-target variables, and the way *_LDFLAGS variables were
     considered internally.
 
+  - subdir-object mode works now with Fortran (F77, FC, preprocessed
+    Fortran, and Ratfor) and Assembler compilation.
+
 * New installation targets:
 
   - New targets mandated by GNU Coding Standards:
Index: tests/nobase.test
===================================================================
RCS file: /cvs/automake/automake/tests/nobase.test,v
retrieving revision 1.16
diff -u -r1.16 nobase.test
--- tests/nobase.test   18 Mar 2006 06:32:36 -0000      1.16
+++ tests/nobase.test   3 Sep 2006 07:33:01 -0000
@@ -116,14 +116,6 @@
 $AUTOMAKE -a --copy
 ./configure --prefix `pwd`/inst --program-prefix=p
 
-# Remove the 'x' bits just for fun.  (Peter O'Gorman said: "If an
-# upstream source tarball does not use the autotools, it is sometimes
-# easier to build if it is modified to use them. Then a patch is
-# generated, and applied to the unpacked clean sources during the
-# build. patch(1) knows nothing about permissions, so executable bits
-# etc can disappear.")
-chmod a-x install-sh
-
 $MAKE
 $MAKE test-install-data
 $MAKE test-install-exec