How to properly define package-wide flags.

[Benoit Sigoure]

Hello folks,

In a recent discussion with Akim Demaille, we found out that we didn't set
our package-wide flags the same way and he couldn't convince me that his way
was safer/cleaner/etc so maybe you have an idea as to what's best practice:

My approach is to AC_SUBST([AM_*FLAGS], [-package-wide-flags]) in my
configure.ac.

Akim's idea of AM_*FLAGS is that they are not meant to be defined in
configure.ac but in Makefile.ams. His approach is to AC_SUBST([MY_*FLAGS],
[-package-wide-flags]) and then have a common.mk (say at top-level) which
does AM_*FLAGS = $(MY_*FLAGS) and then include that common.mk everywhere it's
required.

According to him, defining package-wide AM_*FLAGS could possibly clash with
that already defined in Makefile.ams. That's true but this would happen only
once (when adding the package-wide flags in the configure.ac) whereas with
his approach, the maintainer has to remember to include common.mk in every
Makefile.am (which is annoying and error prone). He also argues that when
defining target_specific_*FLAGS, the corresponding AM_*FLAGS aren't
automatically included. Personally, I don't see the problem with it.

What do you think about this existential question?

-- 
SIGOURE Benoit aka Tsuna
   _____
  /EPITA\ Promo 2008, LRDE