automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Shouldn't the definition of maintainer-clean be changed?


From: Bruce Korb
Subject: Re: Shouldn't the definition of maintainer-clean be changed?
Date: Tue, 20 Mar 2007 08:36:38 -0700
User-agent: Thunderbird 1.5.0.8 (X11/20060911)

Not knowing the guts of this, my only complaint has to do
with the help text for ``--clean'' and the lack of consistency
WRT ``-c'' being an acceptable alias for it.

Benoit Sigoure wrote:
> Index: autoconf/bin/autoconf.as
> ===================================================================
> RCS file: /sources/autoconf/autoconf/bin/autoconf.as,v
> retrieving revision 1.24
> diff -u -r1.24 autoconf.as
> --- autoconf/bin/autoconf.as  4 Jan 2007 16:43:06 -0000       1.24
> +++ autoconf/bin/autoconf.as  19 Mar 2007 21:04:17 -0000
> @@ -33,6 +33,7 @@
>    -v, --verbose             verbosely report processing
>    -d, --debug               don't remove temporary files
>    -f, --force               consider all files obsolete
> +      --clean               remove all files otherwise installed by autoconf

drop the word, "otherwise" or "all" or see below. :)

> Index: autoconf/bin/autoheader.in
> ===================================================================
> RCS file: /sources/autoconf/autoconf/bin/autoheader.in,v
> retrieving revision 1.147
> diff -u -r1.147 autoheader.in
> --- autoconf/bin/autoheader.in        4 Jan 2007 16:43:06 -0000       1.147
> +++ autoconf/bin/autoheader.in        19 Mar 2007 21:04:17 -0000
> @@ -70,6 +70,7 @@
>    -h, --help               print this help, then exit
>    -V, --version            print version number, then exit
>    -v, --verbose            verbosely report processing
> +      --clean              remove the files that would otherwise be created

Here, "otherwise" works.  However, the descriptions ought to be the same.
I think simply, ``remove files installed by ${program}'' everywhere.

> Index: autoconf/bin/autoreconf.in
> ===================================================================
> RCS file: /sources/autoconf/autoconf/bin/autoreconf.in,v
> retrieving revision 1.137
> diff -u -r1.137 autoreconf.in
> --- autoconf/bin/autoreconf.in        4 Jan 2007 16:43:06 -0000       1.137
> +++ autoconf/bin/autoreconf.in        19 Mar 2007 21:04:17 -0000
> @@ -74,6 +74,7 @@
>    -d, --debug              don't remove temporary files
>    -f, --force              consider all files obsolete
>    -i, --install            copy missing auxiliary files
> +  -c, --clean              remove auxiliary files

Another variation?  WRT ``-c'', either all have the short option
or none do, please.

> Index: automake/aclocal.in
> ===================================================================
> RCS file: /sources/automake/automake/aclocal.in,v
> retrieving revision 1.140
> diff -u -r1.140 aclocal.in
> --- automake/aclocal.in       14 Oct 2006 17:40:25 -0000      1.140
> +++ automake/aclocal.in       19 Mar 2007 21:04:23 -0000

> @@ -861,6 +880,7 @@
>                                changed (implies --install and --dry-run)
>        --dry-run             pretend to, but do not actually update any file
>        --force               always update output file
> +  -c, --clean               remove the files that would otherwise be 
> generated

consistency, consistency and more consistency, without good reason otherwise
anyway.

> Index: libtool/libtoolize.m4sh
> ===================================================================
> RCS file: /sources/libtool/libtool/libtoolize.m4sh,v
> retrieving revision 1.60
> diff -u -r1.60 libtoolize.m4sh
> --- libtool/libtoolize.m4sh   9 Mar 2007 15:08:43 -0000       1.60
> +++ libtool/libtoolize.m4sh   19 Mar 2007 21:04:29 -0000
> @@ -39,6 +39,7 @@
>  # -n, --dry-run         print commands rather than running them
>  # -f, --force           replace existing files
>  # -i, --install         copy missing auxiliary files
> +#     --clean           remove auxiliary files




reply via email to

[Prev in Thread] Current Thread [Next in Thread]