Re: [PATCH] build: use AC_CONFIG_HEADERS, not AM_CONFIG_HEADER

[Stefano Lattarini]

On 12/30/2012 10:35 AM, Paolo Bonzini wrote:
> Il 29/12/2012 21:43, Stefano Lattarini ha scritto:
>> On 12/29/2012 08:46 PM, Paolo Bonzini wrote:
>>> Il 29/12/2012 17:32, Stefano Lattarini ha scritto:
>>>> * configure.ac: Here.  The latter has been removed in Automake 1.13.
>>>
>>> Is there any reason for this,
>>>
>> Avoiding to keep too much cruft around the codebase, and smoothing
>> possible future transitions to Automake-NG.
> 
> Two lines of code are not "cruft".  It's only cruft if it happens
> _outside_ the definition of AM_CONFIG_HEADER itself.
> 
>>> apart from randomly breaking
>>> perfectly-working packages?
>>>
>>> The right way to do this is to rely on the autoupdate machinery.
>>>
>> I thought I had deprecated this macro in the 1.12.x series already,
>> with proper warnings.  Wasn't that the case?
> 
> Deprecating is different from letting autoupdate convert it automatically.
>
At any rate, I agree the error message caused by the abrupt removal
is horrible.  I'll soon post a patch to have still-exiting uses of
AM_CONFIG_HEADER give a clear error message (as is done for the
AM_C_PROTOTYPES since Automake 1.12).  Making that fix quickly
available will be a good reason for a 1.13.1 release.

> [SNIP]

Regards,
  Stefano