[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: t/aclocal-print-acdir.sh at installcheck and AUTOMAKE_UNINSTALLED
From: |
Mathieu Lirzin |
Subject: |
Re: t/aclocal-print-acdir.sh at installcheck and AUTOMAKE_UNINSTALLED |
Date: |
Wed, 05 Feb 2020 23:43:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello Karl,
Karl Berry <address@hidden> writes:
> Hi Mathieu - I'm glad you replied. I saw in the ChangeLog that you
> created AUTOMAKE_UNINSTALLED :). The general idea was clear, but all the
> implications, not so much.
>
> Here is a patch that seem to fix the issue, I have added some clutter to
> AM_TESTS_ENVIRONMENT
>
> Thanks! make distcheck now passes completely, all three failing tests
> are fixed, with both python2 and python3. That is great.
>
> The only trivial thing I would ask is that I would appreciate not
> breaking new ground with the UTF-8 quotes in the comment, since they are
> not really necessary (the comment is just as understandable with no
> quote characters, or '...' if you prefer). There are no UTF-8 quotes in
> the main source files now.
> +# the pre-inst-env wrapper script.
Sure that was not intentional.
> Other than that, please push asap! --thanks again, karl.
I Will push that patch before the end of the week.
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37