bug-autoconf
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

tests/Makefile.am VPATH


From: Ralf Wildenhues
Subject: tests/Makefile.am VPATH
Date: Sat, 22 May 2004 12:32:51 +0200
User-agent: Mutt/1.5.5.1+cvs20040105i

The following patch against Autoconf CVS HEAD fixes 'make check' in
a VPATH build.  Interestingly, the comment above the bad line
explains why it should be this way!?  So I wonder whether this is
the right fix.  Maybe someone changed this because of some make
which had a broken VPATH dependency checking?

Anyway, the bug this fixes is reproduced by
$ rm -f $srcdir/tests/aclang.at 
$ make check  # in a VPATH build
[...]
make[2]: Entering directory `/home/ralf/download/cvs/autoconf/build/tests'
cd ../../tests && ./mktests.sh ../../lib/autoconf/general.m4 
../../lib/autoconf/status.m4 ../../lib/autoconf/autoheader.m4 
../../lib/autoconf/autoupdate.m4 ../../lib/autoconf/specific.m4 
../../lib/autoconf/functions.m4 ../../lib/autoconf/lang.m4 
../../lib/autoconf/c.m4 ../../lib/autoconf/fortran.m4 
../../lib/autoconf/headers.m4 ../../lib/autoconf/libs.m4 
../../lib/autoconf/types.m4 ../../lib/autoconf/programs.m4
cat: ../../lib/autoconf/general.m4: No such file or directory
[...]


Furthermore, there is the (important?) unrelated warning

make[2]: Entering directory `/home/ralf/download/cvs/autoconf/build/tests'
make[2]: Circular ../tests/autom4te <- ../../tests/wrapper.in dependency 
dropped.

before this.

Regards,
Ralf

* tests/Makefile.am:  Do not use $(srcdir) for autoconfdir,
as indicated by the comment.

Index: tests/Makefile.am
===================================================================
RCS file: /cvsroot/autoconf/autoconf/tests/Makefile.am,v
retrieving revision 1.86
diff -u -r1.86 Makefile.am
--- tests/Makefile.am   18 Feb 2004 21:34:44 -0000      1.86
+++ tests/Makefile.am   22 May 2004 10:20:04 -0000
@@ -121,7 +121,7 @@
 # The files which contains macro we check for syntax.  Don't use $(top_srcdir)
 # here since below we explicitly `cd' to $srcdir.  As for the dependencies,
 # thanks God for VPATH.  Hm...
-autoconfdir = $(top_srcdir)/lib/autoconf
+autoconfdir = ../lib/autoconf
 AUTOCONF_FILES = $(autoconfdir)/general.m4 \
                 $(autoconfdir)/status.m4 \
                 $(autoconfdir)/autoheader.m4 \




reply via email to

[Prev in Thread] Current Thread [Next in Thread]