m4sugar: m4_divert

[Stepan Kasal]

Hello,
  I'd like to ask about the macro m4_divert in m4sugar.m4 .
This macro doesn't cooperate wel with m4_divert_{push,pop}.

For example:

m4_divert_push([ONE])
m4_divert([TWO])
m4_divert_push([THREE])
m4_divert_pop()

leaves you with text diverted to _m4_divert(ONE), not _m4_divert(TWO),
as one would expect.

I searched the autoconf sources to find out where is m4_divert used;
there is one instance in m4_require, but that can be changed easily, and
autoconf.m4 has ``m4_copy_unm4([m4_divert])'' and that's all.

But can a user macro use (m4_)divert safely?
Shouldn't it use m4_divert_text instead?

What would you think about removing m4_divert from m4sugar?
(Akim, what do you think?)

(I haven't run ``make check'' yet, but I'd surely run it before I proposed
any patch.)

Regards,
        Stepan Kasal