[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: top_builddir vs. builddir
From: |
Stepan Kasal |
Subject: |
Re: top_builddir vs. builddir |
Date: |
Tue, 1 Feb 2005 16:38:44 +0100 |
User-agent: |
Mutt/1.4.1i |
Hi,
On Mon, Jan 31, 2005 at 11:52:11AM -0800, Paul Eggert wrote:
> > + test -z "$ac_top_builddir" && ac_top_builddir=.
>
> This doesn't look right to me. ac_top_builddir looks like this:
> "../../../../". That is, it's of the form (../)*. So it is a file
> name prefix, not a file name, and it should be empty if it's the
> current directory.
the problem is that this is not consistent with Automake, which defines
top_builddir = .
top_builddir = ..
top_builddir = ../..
etc.
(Automake doesn't use @top_builddir@ substitution.)
So, with automake, one can use $(top_builddir)/subdir/file
With pure autoconf, this is also possible for all dirs but the topmost,
because eg ..//subdir/file also works.
To maintain compatibility with both worlds, I suggest to set
ac_top_builddir to "./" instead of mere "."
(Please note that I have put the assignment after all places where autoconf
itself uses the variable, so that no other autoconf output variable will be
modified.)
Can I commit the attached variation of my patch?
Have a nice day,
Stepan
ac_top_builddir.patch
Description: Text document
- Re: top_builddir vs. builddir,
Stepan Kasal <=