bug-autoconf
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Spurious datarootdir warnings in Wine configure


From: Alexandre Julliard
Subject: Re: Spurious datarootdir warnings in Wine configure
Date: Tue, 20 Jun 2006 13:05:20 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Ralf Wildenhues <address@hidden> writes:

> * Alexandre Julliard wrote on Mon, Jun 19, 2006 at 05:50:04PM CEST:
>> Ralf Wildenhues <address@hidden> writes:
>> > * Alexandre Julliard wrote on Mon, Jun 19, 2006 at 01:23:13PM CEST:
>> >> I'm happy to add a workaround in Wine if you can suggest one,
>> >> preferably one that doesn't involve defining datarootdir in every
>> >> individual makefile...
>> >
>> > Yes.  If you don't mind, you could add this line
>
>> Well, that isn't much better than defining it, since we have to do it
>> in all the files. We currently have about 300 makefiles, so having to
>> maintain that sort of thing in all of them is annoying.
>
> OK.  We need a way to turn this mechanism off.  Stay tuned.

FWIW, here's a patch to test if datarootdir is defined in the output
file, to avoid printing the warning in that case. It solves the
problem for Wine.

Index: lib/autoconf/status.m4
===================================================================
RCS file: /sources/autoconf/autoconf/lib/autoconf/status.m4,v
retrieving revision 1.114
diff -u -p -r1.114 status.m4
--- lib/autoconf/status.m4      30 May 2006 05:47:40 -0000      1.114
+++ lib/autoconf/status.m4      20 Jun 2006 10:57:48 -0000
@@ -555,6 +555,7 @@ $ac_datarootdir_hack
 
 test -z "$ac_datarootdir_hack$ac_datarootdir_seen" &&
   { ac_out=`sed -n '/\${datarootdir}/p' "$tmp/out"`; test -n "$ac_out"; } &&
+  { ac_out=`sed -n '/^[[       ]]*datarootdir[[        ]]*:*=/p' "$tmp/out"`; 
test -z "$ac_out"; } &&
   AC_MSG_WARN([$ac_file contains a reference to the variable `datarootdir'
 which seems to be undefined.  Please make sure it is defined.])
 

-- 
Alexandre Julliard
address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]