bug-autoconf
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [BUG] CR handling related autoconf problem


From: Eric Blake
Subject: Re: [BUG] CR handling related autoconf problem
Date: Tue, 24 Mar 2009 06:49:29 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090302 Thunderbird/2.0.0.21 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Andris Pavenis on 3/20/2009 12:28 PM:
> The awk script subs.awk generated by config.status contains
> \r at end of each line instead of real CR (see attachment
> for an example). As result awk fails with an error message:

That indeed looks like a typo in our generation of ac_cs_awk_cr (we wanted
either "\\r" or '\r', because we want the two bytes \r in the awk script
matching what we just tested earlier).  I've pushed your patch.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknI1tkACgkQ84KuGfSFAYDK2QCfbHoZ1TxEUVQCAws8nZBVXz6I
y68AoKPP0zZUNYdbbKaztU3lUehv8owZ
=ic7T
-----END PGP SIGNATURE-----
>From bc9bc82a1e5615c6a7bca8bb9800427ac73625ce Mon Sep 17 00:00:00 2001
From: Andris Pavenis <address@hidden>
Date: Tue, 24 Mar 2009 06:47:09 -0600
Subject: [PATCH] Fix awk substitution of carriage returns on DJGPP.

* lib/autoconf/status.m4 (_AC_OUTPUT_FILES_PREPARE): Fix typo in
generation of ac_cs_awk_cr.
* THANKS: Update.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog              |    7 +++++++
 THANKS                 |    1 +
 lib/autoconf/status.m4 |    2 +-
 3 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6bb006e..b565525 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-03-24  Andris Pavenis  <address@hidden>  (tiny change)
+
+       Fix awk substitution of carriage returns on DJGPP.
+       * lib/autoconf/status.m4 (_AC_OUTPUT_FILES_PREPARE): Fix typo in
+       generation of ac_cs_awk_cr.
+       * THANKS: Update.
+
 2009-03-24  Aaron W. LaFramboise  <address@hidden>  (tiny change)

        Work around cygwin bash igncr mode.
diff --git a/THANKS b/THANKS
index 019d9fd..77da1dd 100644
--- a/THANKS
+++ b/THANKS
diff --git a/lib/autoconf/status.m4 b/lib/autoconf/status.m4
index 0e118f2..72e6893 100644
--- a/lib/autoconf/status.m4
+++ b/lib/autoconf/status.m4
@@ -385,7 +385,7 @@ if test "x$ac_cr" = x; then
 fi
 ac_cs_awk_cr=`$AWK 'BEGIN { print "a\rb" }' </dev/null 2>/dev/null`
 if test "$ac_cs_awk_cr" = "a${ac_cr}b"; then
-  ac_cs_awk_cr='\\r'
+  ac_cs_awk_cr='\r'
 else
   ac_cs_awk_cr=$ac_cr
 fi
-- 
1.6.1.2


reply via email to

[Prev in Thread] Current Thread [Next in Thread]