Re: [2.64] Test "Hard fail" fails on Darwin

[Ralf Wildenhues]

Hello Ludovic,

thanks for the bug report.

* Ludovic Courtès wrote on Wed, Jul 29, 2009 at 10:15:44AM CEST:
> The "Hard fail" test fails on NixOS i686-darwin (see
> http://hydra.nixos.org/build/53808; see
> http://hydra.nixos.org/job/nixpkgs/trunk/autoconf/all for all Autoconf
> builds).

> PATH: 
> /private/tmp/nix-build-dnnfpb1bi3bwf696k09s44l2p9s0ppgw-autoconf-2.64.drv-0/autoconf-2.64/tests
> PATH: /nix/store/xra8dla43v4y3icyz81p9jdcmphnwjny-gnum4-1.4.13/bin
[...]

Ahh, I've read about this concept but haven't seen it in action yet.
Do the long directory names slow down the system much in practice?

> 114. autotest.at:266: testing ...
[...]
> ./autotest.at:266: grep '2 failed unexpectedly' micro-suite.log
> stdout:
> 2 failed unexpectedly.
> ./autotest.at:266: grep ok micro-suite.log
> --- /dev/null 2009-07-28 19:44:41.000000000 +0000
> +++ 
> /private/tmp/nix-build-dnnfpb1bi3bwf696k09s44l2p9s0ppgw-autoconf-2.64.drv-0/autoconf-2.64/tests/testsuite.dir/at-groups/114/stdout
>         2009-07-28 19:44:41.000000000 +0000
> @@ -0,0 +1 @@
> +hostname = token.local
> ./autotest.at:266: exit code was 0, expected 1
> micro-suite.log:
[...]
> > ## --------- ##
> > ## Platform. ##
> > ## --------- ##
> > 
> > hostname = token.local
[...]
> > /micro-suite.at:8: hard failure
> > 2. micro-suite.at:6: 2. another test (micro-suite.at:6): FAILED 
> > (micro-suite.at:8)
> > 
> 114. autotest.at:266: 114. Hard fail (autotest.at:266): FAILED 
> (autotest.at:266)

This is a trivial failure due to a test that is not restrictive enough.
The grep tries to find out if any of the tests in the micro testsuite
succeeded bogusly; however, it is too lax and also matches the line that
lists your host name.  I'm applying the patch below to make the test
more restrictive.

Cheers,
Ralf

    testsuite: avoid bogus hostname match from inner test logs.
    
    * tests/autotest.at (Hard fail): Check more restrictively for
    passed tests, so that hostnames recorded in the log file do not
    wrongly match.
    Report by Ludovic Courtès.

diff --git a/tests/autotest.at b/tests/autotest.at
index 57382ca..7836439 100644
--- a/tests/autotest.at
+++ b/tests/autotest.at
@@ -271,7 +271,7 @@ AT_CHECK_AT_TEST([Hard fail],
    AT_CHECK([exit 99])],
   [], [1], [], [ignore], [],
   [AT_CHECK([grep '2 failed unexpectedly' micro-suite.log], [], [ignore])
-   AT_CHECK([grep ok micro-suite.log], [1])])
+   AT_CHECK([grep '^[[12]].*ok' micro-suite.log], [1])])
 
 AT_CHECK_AT_TEST([AT@&address@hidden,
   [AT_FAIL_IF([:])