[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: "The `-a', `-o', `(', and `)' operands are not portable": please cla
From: |
Eric Blake |
Subject: |
Re: "The `-a', `-o', `(', and `)' operands are not portable": please clarify |
Date: |
Thu, 10 Sep 2009 20:17:56 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Reuben Thomas on 8/12/2009 8:08 AM:
> When I actually looked at the manual in git, almost everything you
> mentioned was already documented, except for two things:
>
> 1. The hint you gave about AS_INIT being automatically called in
> configure and config.status. I attach a patch to remedy that.
>
> 2. The bits about AS_REQUIRE_SHELL_FN. But that macro is not yet
> documented anyway.
>
> diff --git a/doc/autoconf.texi b/doc/autoconf.texi
> index 6bac0c3..c441ff3 100644
> --- a/doc/autoconf.texi
> +++ b/doc/autoconf.texi
> @@ -12939,7 +12939,8 @@ generated from, and code to sanitize the environment
> for the rest of the
> script. Among other initializations, this sets @env{SHELL} to the shell
> chosen to run the script (@pxref{CONFIG_SHELL}), and @env{LC_ALL} to
> ensure the C locale. Finally, it changes the current diversion to
> address@hidden
> address@hidden @code{AS_INIT} is called automatically in @code{configure}
> +and @code{config.status}.
Thanks for the idea. I ended up rewording it a bit (configure is a shell
script, and shell scripts don't call m4 macros).
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqps1QACgkQ84KuGfSFAYA2zACcCHanwvUxhX4a0ig+yBpZymDo
DgcAmgIO72imzPEWEdBlnI/nt2a905Rp
=buaK
-----END PGP SIGNATURE-----
>From 4d490cb54907bce022a338ad908a0d3dc956bb53 Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Thu, 10 Sep 2009 20:16:46 -0600
Subject: [PATCH] Document that AS_INIT is automatically used.
* doc/autoconf.texi (Initialization Macros) <AS_INIT>: Add words
to clarify that only bare-bones scripts need a direct AS_INIT.
Suggested by Reuben Thomas.
Signed-off-by: Eric Blake <address@hidden>
---
ChangeLog | 6 ++++++
doc/autoconf.texi | 5 ++++-
2 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index ff99666..529dfaf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,8 +1,14 @@
2009-09-10 Eric Blake <address@hidden>
+ Document that AS_INIT is automatically used.
+ * doc/autoconf.texi (Initialization Macros) <AS_INIT>: Add words
+ to clarify that only bare-bones scripts need a direct AS_INIT.
+ Suggested by Reuben Thomas.
+
Clarify portability pitfall of test.
* doc/autoconf.texi (Limitations of Builtins) <test>: Give more
reasons why -a and -o are not portable.
+ Reported by Reuben Thomas.
2009-09-04 Reuben Thomas <address@hidden> (tiny change)
diff --git a/doc/autoconf.texi b/doc/autoconf.texi
index 36eba53..669e812 100644
--- a/doc/autoconf.texi
+++ b/doc/autoconf.texi
@@ -12941,7 +12941,10 @@ Initialization Macros
script. Among other initializations, this sets @env{SHELL} to the shell
chosen to run the script (@pxref{CONFIG_SHELL}), and @env{LC_ALL} to
ensure the C locale. Finally, it changes the current diversion to
address@hidden
address@hidden @code{AS_INIT} is called automatically by @code{AC_INIT}
+and @code{AT_INIT}, so shell code in @file{configure},
address@hidden, and @file{testsuite} all benefit from a sanitized
+shell environment.
@end defmac
@defmac AS_INIT_GENERATED (@var{file}, @ovar{comment})
--
1.6.3.3.334.g916e1