[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix libtool test
From: |
Eric Blake |
Subject: |
Re: fix libtool test |
Date: |
Thu, 26 Nov 2009 05:07:53 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
[moving to autoconf-patches, replies can drop bug-autoconf]
According to Stepan Kasal on 11/25/2009 6:05 PM:
> Hello,
> I noticed that the libtool test is always skipped (foreign.at, line
> 58), as libtoolize does not install config.guess.
I have noticed that too, but never had time to look into it, so thanks.
>
> A side note:
> I noticed that the option --install to libtoolize is not mentioned in
> libtool info documentation.
Would you please report that on bug-libtool?
> +# Build the concatenation of libtool m4 files and configure.ac.
> +AT_CHECK([cat `cat stdout` >configure.in])
> cat >>configure.in <<_EOF
Why not:
AT_CHECK([cat `cat stdout` <<_EOF >configure.in
...
EOF
])
to save on cat processes (it's not every day you see a valid use of two
cat processes in the same command line ;).
Beyond that, it looks good to me. Go ahead and commit; if there's any
fallout with failures due to really old libtool, we still have some time
before the next release to find and flush them out.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAksOb5kACgkQ84KuGfSFAYD0cgCeKxSZd4llJXkis9tFqFydnYT+
o/0AoLXVhlYDAJaR0kpOZu1avr2As7gh
=yiVX
-----END PGP SIGNATURE-----