bug-autoconf
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: autoconf-2.65 on UnixWare 7.1.4


From: Ralf Wildenhues
Subject: Re: autoconf-2.65 on UnixWare 7.1.4
Date: Mon, 18 Jan 2010 20:29:54 +0100
User-agent: Mutt/1.5.20 (2009-10-28)

* Tim Rice wrote on Mon, Jan 18, 2010 at 07:17:52PM CET:
> On Sat, 16 Jan 2010, Ralf Wildenhues wrote:
> > * Tim Rice wrote on Wed, Jan 13, 2010 at 03:28:49AM CET:
> > > The bash I built back in 2006 was version 3.1.17(1)-release
> > > With that we get testsuite: 74 211 failed
> > > I started working on building bash-4.1 last night.
> > > When I get that built, I'll see if it works any better.
> > 
> > Thanks.  I'd be interested in the global testsuite.log file, for both of
> > these shells (edit out confidential information if you need to).
> 
> Attached.
> bash 4.1 only failed test 211 which is interesting because if I then do
> gmake -C tests clean
> gmake check MAKE=gmake TESTSUITEFLAGS='-v -d -x 127 
> CONFIG_SHELL=/opt/bin/bash'
> it passes.

Mixup?  211 vs 127?

Anyway, the failure of 211 is easy, and due to 'false' exiting 255 on
your system rather than 1 (which is documented in autoconf.texi).
Please confirm that the patch below fixes the issue; the test addition
is to ensure the respective code path for $srcdir != '.' is covered as
well.

Thanks,
Ralf

    config.status: consistent exit status with nonexistent config file input.
    
    * lib/autoconf/status.m4 (_AC_OUTPUT_MAIN_LOOP): Ensure we
    exit with status 1 rather than with that of 'false', for
    reproducibility.
    * tests/torture.at (Missing templates): Also test code path
    for $srcdir != '.'.
    Report by Tim Rice.

diff --git a/lib/autoconf/status.m4 b/lib/autoconf/status.m4
index 3c6cf38..62003c5 100644
--- a/lib/autoconf/status.m4
+++ b/lib/autoconf/status.m4
@@ -1666,7 +1666,7 @@ do
           [[\\/$]]*) false;;
           *) test -f "$srcdir/$ac_f" && ac_f="$srcdir/$ac_f";;
           esac ||
-          AC_MSG_ERROR([cannot find input file: `$ac_f']);;
+          AC_MSG_ERROR([cannot find input file: `$ac_f'], [1]);;
       esac
       case $ac_f in *\'*) ac_f=`AS_ECHO(["$ac_f"]) | sed 
"s/'/'\\\\\\\\''/g"`;; esac
       AS_VAR_APPEND([ac_file_inputs], [" '$ac_f'"])
diff --git a/tests/torture.at b/tests/torture.at
index ceea62c..8291694 100644
--- a/tests/torture.at
+++ b/tests/torture.at
@@ -370,6 +370,15 @@ AC_OUTPUT
 ]])
 
 AT_CHECK_AUTOCONF
+mkdir build
+AT_CAPTURE_FILE([build/config.log])[]dnl
+cd build
+AT_CHECK([../configure], [1], [ignore],
+[[config.status: error: cannot find input file: `nonexistent.in'
+]])
+# Make sure that the output file doesn't exist
+AT_CHECK([test -f nonexistent], 1)
+cd ..
 AT_CHECK_CONFIGURE([], [1], [],
 [[config.status: error: cannot find input file: `nonexistent.in'
 ]])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]